Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSG-634: Update Comet Starter App with Keycloak integration #18

Merged
merged 10 commits into from
Aug 24, 2023
Merged

CSG-634: Update Comet Starter App with Keycloak integration #18

merged 10 commits into from
Aug 24, 2023

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Aug 21, 2023

Provide baseline for starter app authentication.

Description

  • Added keycloak config and dependencies
  • Updated signin page with SSO button
  • Updated auth flow to support SSO signin
  • Added Protected Routes component and updated routes as needed

Related Issue

#2

Motivation and Context

  • Provide auth baseline

How Has This Been Tested?

Local testing, verified e2e testing

Screenshots (if appropriate):

Screenshot 2023-08-21 at 5 09 00 PM

@jbouder jbouder added the enhancement New feature or request label Aug 21, 2023
LuisdelaVega
LuisdelaVega requested changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@LuisdelaVega LuisdelaVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted an idea to minimize boilerplate when using the Protected Route component. Let me know if you agree

src/components/protected-route/protected-route.tsx Show resolved Hide resolved
LuisdelaVega
LuisdelaVega approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@LuisdelaVega LuisdelaVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@jbouder jbouder marked this pull request as ready for review August 23, 2023 14:10
@jbouder jbouder merged commit c2c1929 into main Aug 24, 2023
5 checks passed
@jbouder jbouder deleted the CSG-634-2 branch August 24, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisdelaVega LuisdelaVega LuisdelaVega approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbouder @LuisdelaVega