CSG-994: Add React Hook Forms to Comet Starter App #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbouder
added
enhancement
ldelavegalopez-metrostar
approved these changes
Aug 25, 2023
| @@ -24,7 +24,7 @@ describe('signin spec', () => { | |||
| cy.signIn('test', '12345678'); | |||
|
|
|||
| // Verify Homepage after signin | |||
| cy.get('h1').should('contain', 'Welcome John Doe'); | |||
| cy.get('h1').should('contain', 'My Dashboard'); | |||
There was a problem hiding this comment.
We should have these Cypress tests run for each PR so we can catch these.
There was a problem hiding this comment.
Yeah I would like to do that, the only issue is we need to have the app deployed somewhere to run against. Thought about deploying to GitHub pages, but the root URL changes a bit and would need some fine-tuning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional tool to accelerate development.
Description
Related Issue
N/A
Motivation and Context
More modern, industry standard for form validation
How Has This Been Tested?
Screenshots (if appropriate):