Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ensure main content area fills display height. #268

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Jul 1, 2024

Ensure the app height is filled regardless of screen size

Description

  • Removed unnecessary div from to main component
  • Updates to base styling to ensure body is 100% and main area flexes to fill

Related Issue

N/A

Motivation and Context

Better user experience

How Has This Been Tested?

Local Testing

Screenshots (if appropriate):

Screenshot 2024-07-01 at 10 15 30 AM Screenshot 2024-07-01 at 10 15 45 AM Screenshot 2024-07-01 at 10 16 11 AM

@jbouder jbouder added the enhancement New feature or request label Jul 1, 2024
@kildre
Copy link
Collaborator

kildre commented Jul 1, 2024

Looks good.

Copy link
Collaborator

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jbouder jbouder merged commit bb9ab96 into main Jul 1, 2024
5 checks passed
@jbouder jbouder deleted the layout-updates branch July 1, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants