Skip to content

Feat/standadized - #997

Merged
nanaf6203-bit merged 8 commits into
MettaChain:mainfrom
nafiuishaaq:feat/standadized
Jul 27, 2026
Merged

Feat/standadized#997
nanaf6203-bit merged 8 commits into
MettaChain:mainfrom
nafiuishaaq:feat/standadized

Conversation

@nafiuishaaq

Copy link
Copy Markdown
Contributor

✅ GraphQL Successfully Removed (Option B Implemented)

1. Deleted GraphQL Resolver Files

  • src/users/users.resolver.ts - Deleted
  • src/properties/properties.resolver.ts - Deleted

closes #905

2. Removed GraphQL-Specific Auth Infrastructure

  • src/auth/guards/gql-auth.guard.ts - Deleted
  • src/auth/decorators/gql-user.decorator.ts - Deleted

closes #906

3. Cleaned up AppModule

  • Removed GraphQLModule, ApolloDriver, ApolloDriverConfig imports
  • Removed the entire GraphQLModule.forRoot() configuration
  • Cleaned up unused imports like join from path

4. Updated Properties Module

  • Removed PropertiesResolver import and provider
  • Removed PubSub import and PUB_SUB provider that was used for GraphQL subscriptions
  • Cleaned up the providers array

closes #907

5. Updated Users Module

  • Removed UsersResolver import and provider
  • Cleaned up the providers array

closes #908

6. All REST API Controllers Intact

The fully implemented REST API remains completely functional with all 40+ controllers still in place, including:

  • UsersController
  • PropertiesController
  • TransactionsController
  • DocumentsController
  • And all other entity controllers

🚀 Current State

The project now exclusively uses REST APIs which are fully implemented across all entities, with no leftover GraphQL stubs or incomplete implementations. The codebase is cleaner and focused on the working REST architecture that has complete controller implementations for all entities.

@drips-wave

drips-wave Bot commented Jul 27, 2026

Copy link
Copy Markdown

@nafiuishaaq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nanaf6203-bit nanaf6203-bit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanaf6203-bit
nanaf6203-bit merged commit fd7acb3 into MettaChain:main Jul 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants