Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chascin, Ryans Implementation #612

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MidnightNinja83
Copy link

Created a solution to get the exchange rates.

  • I utilize the onion architecture pattern to ensure clean architecture and allow easy access to both the console and web versions of the app.
  • Unit tests are omitted from this version due mostly to the simplicity of the action.
  • I utilized a memory cache to reduce the calls required to the API endpoint.
  • The API endpoint could have used a more simplified return type, but remained as it was to allow for further discusson of transformation patterns, and the impacts on what feature requests might come to change the shape of an API endpoint
  • Logging was omitted at this time for the same reason.
  • Observability was omitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant