Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async await improvements #229

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Async await improvements #229

merged 2 commits into from
Oct 30, 2023

Conversation

abdallahbeshi
Copy link
Contributor

@abdallahbeshi abdallahbeshi commented Oct 30, 2023 •
edited
Loading

Description

async/await is preferred over directly returning Task

image

Type of change

  • Bug fix.
  • Feature.
  • Consolidation.

Checklist

  • Is breaking change.
  • Documentation updated.
  • Tests included (please specify cases).

@abdallahbeshi abdallahbeshi merged commit ef33b1e into master Oct 30, 2023
9 checks passed
@abdallahbeshi abdallahbeshi deleted the async-await-improvements branch October 30, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inakiesteve inakiesteve inakiesteve approved these changes

@tonyjoanes tonyjoanes Awaiting requested review from tonyjoanes

Assignees

@inakiesteve inakiesteve

@abdallahbeshi abdallahbeshi

Labels
b2b.expansion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdallahbeshi @inakiesteve