Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TicketBAI - Introduced simplified invoices and improved error handling #244

Merged
merged 3 commits into from
Feb 6, 2024
Merged

TicketBAI - Introduced simplified invoices and improved error handling #244

merged 3 commits into from
Feb 6, 2024

Conversation

abdallahbeshi
Copy link
Contributor

@abdallahbeshi abdallahbeshi commented Feb 6, 2024 •
edited
Loading

Description

TicketBAI - Introduced simplified invoices and improved error handling.

Type of change

  • Bug fix.
  • Feature.
  • Consolidation.

Checklist

  • Is breaking change.
  • Documentation updated.
  • Tests included.

@abdallahbeshi abdallahbeshi enabled auto-merge (squash) February 6, 2024 13:48
inakiesteve
inakiesteve reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@inakiesteve inakiesteve left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment regarding the use of the Jwt package

src/Mews.Fiscalizations.All/Mews.Fiscalizations.All.csproj Outdated Show resolved Hide resolved
@abdallahbeshi abdallahbeshi merged commit 8d34125 into master Feb 6, 2024
5 checks passed
@abdallahbeshi abdallahbeshi deleted the bizkaia-error-handling-1 branch February 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inakiesteve inakiesteve inakiesteve approved these changes

Assignees

@inakiesteve inakiesteve

@abdallahbeshi abdallahbeshi

Labels
b2b.expansion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdallahbeshi @inakiesteve