Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwarp angles before plotting them. #601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ValerioMagnago
Copy link
Contributor

Jumps in the angle plot make hard to compare different trajectory. In this commit we unwrap the angles before plotting them.

Before:
hard_to_read

After:
easier_to_read

Jumps in the angle plot make hard to compare different trajectory.
In this commit we unwrap the angles before plotting them.
@MichaelGrupp
Copy link
Owner

Please don't change the default and make this an option (for the function and in the CLI or settings). I would only see this as meaningful when dealing with pure 2d rotation, but also there someone might want to see the absolute values instead.

Also note that for the purpose of rotation comparison, the rotation error metrics in RPE/APE are generally more stable than anything that is based on Euler angles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants