Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperating dimmer and dmx logic #160

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Seperating dimmer and dmx logic #160

merged 1 commit into from
Oct 16, 2024

Conversation

MichielVanwelsenaere
Copy link
Owner

Pull Request Checklist

Check if the tasks below are relevant for your PR, to mark an item as completed use [X].

  • I followed the CONTRIBUTING.md
  • Updated the PLCOpen XML export file (only relevant on code change).
  • Updated the CoDeSys V3 export file (only relevant on code change).
  • Updated or created any relevant documentation.

Proposed Changes

  • Seperates the DMX logic from the analog dimmer. Goal is to create a better view on what is used where and not cramp everything in the same function block.
  • Approach in line with DALI dimmer, which is also seperated from the analog dimmer logic.

Related issues

@MichielVanwelsenaere MichielVanwelsenaere added the enhancement New feature or request label Oct 16, 2024
@MichielVanwelsenaere MichielVanwelsenaere self-assigned this Oct 16, 2024
@MichielVanwelsenaere MichielVanwelsenaere merged commit b3835f1 into master Oct 16, 2024
1 check passed
@MichielVanwelsenaere MichielVanwelsenaere deleted the feature/dmx-specific-dimmer branch October 16, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MichielVanwelsenaere MichielVanwelsenaere

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seperate dimmer implementations
1 participant
@MichielVanwelsenaere