Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing bug on DALI Dimmer #164

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fixing bug on DALI Dimmer #164

merged 1 commit into from
Dec 2, 2024

Conversation

MichielVanwelsenaere
Copy link
Owner

Pull Request Checklist

Check if the tasks below are relevant for your PR, to mark an item as completed use [X].

  • I followed the CONTRIBUTING.md
  • Updated the PLCOpen XML export file (only relevant on code change).
  • Updated the CoDeSys V3 export file (only relevant on code change).
  • Updated or created any relevant documentation.

Proposed Changes

  • Fixing scenario where DALI dimmer doesn't turn of if it comes from 1% brightness
  • Syncing DALI fade rate an fade time every 24h to drivers to PLC doesn't have to be restarted in order to push these values to new or resetted DALI drivers.

Related issues

@MichielVanwelsenaere MichielVanwelsenaere added the bug Something isn't working label Dec 2, 2024
@MichielVanwelsenaere MichielVanwelsenaere self-assigned this Dec 2, 2024
@MichielVanwelsenaere MichielVanwelsenaere merged commit 142d843 into master Dec 2, 2024
1 check passed
@MichielVanwelsenaere MichielVanwelsenaere deleted the fix/dali-dimmer-1-percent branch December 2, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MichielVanwelsenaere MichielVanwelsenaere

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DALI Dimmer doesn't react on OFF signal when on 1%
1 participant
@MichielVanwelsenaere