feat: replace clipboard copy with QR code for secret key backup (Closes #348) - #352
Open
waterWang wants to merge 1 commit into
Open
feat: replace clipboard copy with QR code for secret key backup (Closes #348)#352waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
- Add QR code display as the primary secret key backup method - Keep clipboard copy as secondary option with security warning - Add session-level rate limiting (max 1 export per 5 minutes) - Auto-clear clipboard after 30 seconds - Add clipboard risk warning banner after copy - Add comprehensive tests for all new behaviors - Update en.json and es.json translations with new keys - Add fadeIn animation utility class Closes Micopay#348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the SEC-25 security fix: replaces the primary clipboard-copy approach for secret key backup with a QR code display, keeping clipboard as a secondary option with stronger security warnings and rate limiting.
Changes
ExportSecretKeyModal.tsx— New QR code primary backup flowqrcode.react(already in dependencies)i18n updates
en.jsonandes.json:exportKeyQR— QR code section labelexportKeyQRHint— Hint about screenshotting/printing the QR codeexportClipboardWarning— Warning about Android clipboard risksexportRateLimited— Rate limit messageexportKeyError— Error state messageCSS
@keyframes fadeInanimation for the clipboard warning bannerTests
Acceptance Criteria
Closes #348