Fixes for Training 4 for 2025.1 #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To have a more accurate comparison, the time spent on setting up and tearing down the accelerators should be included.
Training 4 document used -O3 number for a fair comparison between hardware and software. However, it was omitted by mistake in the source files. This fixes the optimization level so that users will see similar results to the Training doc.
Instruction on CPU Usage were a bit unclear. The picture shows 11% usage but if were to follow the instructions, it would have been 40%. 11% usage is only achieved after setting SOC_POLL_DELAY to 1000 ms. Also updated: - the source file for main.non_blocking.cpp to include virtual address and line number. - minor formatting in Figure 6-23
siupakmok
force-pushed
the
fix_t4_siu_pak
branch
from
494356b to
bf43f73
Compare
ShuranXuMCHP
reviewed
Apr 3, 2025
| @@ -2578,6 +2593,8 @@ By combining the 2 functions into one, we achieved the following: | |||
| SRCS = main_variations/main.fifo.cpp | |||
| ``` | |||
|
|
|||
| Remove the `set_parameter SOC_POLL_DELAY 1000` line in `config.tcl`, which was added in the [CPU Usage](#cpu-usage-maincpu_usagecpp) section. | |||
There was a problem hiding this comment.
@siupakmok why do we need to remove this setting ?
There was a problem hiding this comment.
This setting changes the polling interval to 1 sec, but the program only runs for ~250 ms.
There was a problem hiding this comment.
SOC_POLL_DELAY is in microseconds, so that's 1ms.
ShuranXuMCHP
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the following changes:
Results from non-blocking with accelerators:
which is around 72 ms as stated in the document.