Skip to content

Moved environment variables outside function to avoid redundancy. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Moved environment variables outside function to avoid redundancy. #13

wants to merge 2 commits into from

Conversation

kefaslungu
Copy link

Removed setting of environment variables from inside function, since it's only required once.

Since the environment variables will only be set once, it's better outside the function since it can be called as many times as necessary, but it's only required to set the key and region once.

@kefaslungu
Removed setting of enviroment variables like region and keys from fun…
e44e9bd 
…ctions, since it's only required once.

Signed-off-by: kefaslungu <[email protected]>
@kefaslungu
Copy link
Author

@microsoft-github-policy-service agree

@prmerger-automator PRMerger Automator
Copy link
Contributor

@kefaslungu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented Sep 5, 2024

@eric-urban

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Sep 5, 2024
@kefaslungu
Copy link
Author

#sign-off

@prmerger-automator PRMerger Automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @eric-urban

@github-actions GitHub Actions
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Sep 29, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit f2e5700:

✅ Validation status: passed

File Status Preview URL Details
articles/ai-services/speech-service/includes/quickstarts/speech-to-text-basics/python.md ✅Succeeded
articles/ai-services/speech-service/includes/quickstarts/speech-translation-basics/python.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-dirichards
Copy link
Contributor

Hi @kefaslungu Thanks for your review. In the public repo, pull requests should be signed off by the author, another member of the content team, or a PM.

@eric-urban
Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Jan 30, 2025
@github-actions GitHub Actions
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Feb 13, 2025
@v-ccolin
Copy link
Contributor

v-ccolin commented Mar 5, 2025

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Mar 5, 2025
@eric-urban
Copy link
Contributor

We'll leave the current implementation for now.
#please-close

learn-build-service-prod bot pushed a commit that referenced this pull request May 19, 2025
@MaanavD
Merge pull request #13 from samuel100/fixing_merge_errors
0ddb5b7 
Fixed suggestions.
learn-build-service-prod bot pushed a commit that referenced this pull request May 19, 2025
@jonburchel
Squashed commit of the following:
b3f8788 
commit 43cf3ee
Merge: 495d9f5 a04ff9e
Author: Diana Richards <[email protected]>
Date:   Mon May 12 12:57:04 2025 -0500

    Merge pull request #4739 from samuel100/samuel100/foundry-local-sdk-updates

    Samuel100/foundry local sdk updates

commit a04ff9e
Author: Diana Richards <[email protected]>
Date:   Mon May 12 12:51:46 2025 -0500

    Apply suggestions from code review

commit 495d9f5
Merge: f756f03 9bbf7d1
Author: Alma Jenks <[email protected]>
Date:   Mon May 12 17:06:03 2025 +0000

    Merge branch 'main' into release-build-foundry-local

commit 6218709
Author: samuel100 <[email protected]>
Date:   Mon May 12 17:12:03 2025 +0100

    remove azure blob requirement

commit abee012
Author: samuel100 <[email protected]>
Date:   Mon May 12 15:42:03 2025 +0100

    fix link

commit 51aa70b
Author: samuel100 <[email protected]>
Date:   Mon May 12 15:30:31 2025 +0100

    updated with guidance on dynamically allocated port.

commit 4e89f2c
Author: samuel100 <[email protected]>
Date:   Mon May 12 15:21:45 2025 +0100

    add example of blob path

commit 8ae019b
Author: samuel100 <[email protected]>
Date:   Mon May 12 14:54:08 2025 +0100

    fixed the dynamic allocation of endpoint

commit d77298a
Author: samuel100 <[email protected]>
Date:   Mon May 12 14:43:57 2025 +0100

    remove c# code for FL

commit 5578a85
Author: samuel100 <[email protected]>
Date:   Mon May 12 14:40:17 2025 +0100

    address feedback

commit 81ad354
Author: samuel100 <[email protected]>
Date:   Sun May 11 18:16:23 2025 +0100

    more details on the request and response.

commit dac2d1d
Author: samuel100 <[email protected]>
Date:   Sun May 11 17:54:31 2025 +0100

    fix embeddings api

commit 98ba922
Author: samuel100 <[email protected]>
Date:   Sun May 11 17:51:29 2025 +0100

    include foundry/list api

commit 031902f
Author: samuel100 <[email protected]>
Date:   Sun May 11 17:37:06 2025 +0100

    typo

commit 5aedc3d
Author: samuel100 <[email protected]>
Date:   Sun May 11 17:35:30 2025 +0100

    reference catalog API updated to latest

commit 8adff40
Author: samuel100 <[email protected]>
Date:   Sun May 11 17:13:21 2025 +0100

    added a bit of commentary on the sdk examples.

commit b785913
Author: samuel100 <[email protected]>
Date:   Sun May 11 16:51:21 2025 +0100

    intro examples

commit 11e9150
Author: samuel100 <[email protected]>
Date:   Sun May 11 16:50:08 2025 +0100

    reference sdk tidy and update

commit b2d6873
Author: samuel100 <[email protected]>
Date:   Sun May 11 15:54:16 2025 +0100

    match output to model in article

commit 781470a
Author: samuel100 <[email protected]>
Date:   Sun May 11 15:47:23 2025 +0100

    fix typo

commit 9ee05e6
Author: samuel100 <[email protected]>
Date:   Sun May 11 15:39:20 2025 +0100

    fix warnings

commit 251fd50
Author: samuel100 <[email protected]>
Date:   Sun May 11 15:25:41 2025 +0100

    fix additional zone-end

commit 5df693c
Author: samuel100 <[email protected]>
Date:   Sun May 11 15:22:26 2025 +0100

    collapse tutorials into how-tos

commit 987a4e4
Author: samuel100 <[email protected]>
Date:   Sun May 11 14:54:06 2025 +0100

    fix zone groups

commit d5b34ea
Author: samuel100 <[email protected]>
Date:   Sun May 11 14:47:41 2025 +0100

    fl sdk added to inferencing sdk docs

commit b635fb7
Author: samuel100 <[email protected]>
Date:   Sun May 11 12:48:42 2025 +0100

    javascript sdks updated with fl sdk

commit 3cc46fa
Author: samuel100 <[email protected]>
Date:   Sun May 11 11:59:55 2025 +0100

    fix tip

commit d23ac13
Author: samuel100 <[email protected]>
Date:   Sun May 11 11:59:39 2025 +0100

    change winget to a tip

commit 8375858
Author: samuel100 <[email protected]>
Date:   Sun May 11 11:54:57 2025 +0100

    include expected output gif in quickstart.

commit 7130bee
Author: samuel100 <[email protected]>
Date:   Sun May 11 11:07:17 2025 +0100

    updates to javascript langchain with foundry sdk

commit 0c1e202
Author: samuel100 <[email protected]>
Date:   Sun May 11 10:03:42 2025 +0100

    acrolinx to 100

commit 9eefe73
Author: samuel100 <[email protected]>
Date:   Sun May 11 09:59:33 2025 +0100

    move files to new location

commit 99dc3e4
Merge: a7fb484 f756f03
Author: samuel100 <[email protected]>
Date:   Sun May 11 09:58:52 2025 +0100

    Merge branch 'release-build-foundry-local' of https://github.com/samuel100/azure-ai-docs-pr into samuel100/foundry-local-sdk-updates

commit f756f03
Merge: 5537cc0 55f7f22
Author: Colin Cooper <[email protected]>
Date:   Sun May 11 09:38:09 2025 +0100

    Merge pull request #4735 from jonburchel/release-build-foundry-local-updates

    [SCOPED] Moving Foundry Local files to /articles/ai-foundry/foundry-local folder.

commit 55f7f22
Author: Jon Burchel <[email protected]>
Date:   Sat May 10 22:09:14 2025 -0400

    Moving Foundry Local files to /articles/ai-foundry/foundry-local folder.

commit 5537cc0
Merge: 38ca6f2 5d02c9d
Author: Anna Huff <[email protected]>
Date:   Sat May 10 16:31:37 2025 -0600

    Merge pull request #3591 from samuel100/samuel100/foundry-local

    Foundry Local

commit a7fb484
Merge: 0602daa 5fb9e73
Author: samuel100 <[email protected]>
Date:   Sat May 10 14:25:30 2025 +0100

    Merge branch 'samuel100/foundry-local-sdk-updates' of https://github.com/samuel100/azure-ai-docs-pr into samuel100/foundry-local-sdk-updates

commit 0602daa
Author: samuel100 <[email protected]>
Date:   Sat May 10 14:25:11 2025 +0100

    python sdk doc on langchain added.

commit 5d02c9d
Author: samuel100 <[email protected]>
Date:   Sat May 10 13:05:26 2025 +0100

    fixed the extra line

commit 1f17d8f
Author: samuel100 <[email protected]>
Date:   Sat May 10 12:55:44 2025 +0100

    fixed missing --- in attributes

commit 5fb9e73
Merge: 4d1f25e 38ca6f2
Author: Samuel Kemp <[email protected]>
Date:   Sat May 10 12:51:34 2025 +0100

    Merge branch 'MicrosoftDocs:main' into samuel100/foundry-local-sdk-updates

commit b5480ae
Author: samuel100 <[email protected]>
Date:   Sat May 10 12:46:17 2025 +0100

    fixed review2 feedback.

commit 0ddb5b7
Merge: 4d1f25e dbb2436
Author: Maanav Dalal <[email protected]>
Date:   Fri May 9 18:50:19 2025 -0400

    Merge pull request #13 from samuel100/fixing_merge_errors

    Fixed suggestions.

commit dbb2436
Author: MaanavD <[email protected]>
Date:   Fri May 9 18:48:52 2025 -0400

    Fixed suggestions.

commit 4d1f25e
Author: samuel100 <[email protected]>
Date:   Fri May 9 21:33:25 2025 +0100

    fixed ms.topic

commit 43e1e38
Author: samuel100 <[email protected]>
Date:   Fri May 9 21:31:26 2025 +0100

    review feedback addressed

commit 0bbab1c
Author: samuel100 <[email protected]>
Date:   Fri May 9 15:06:25 2025 +0100

    another fix

commit a384a1e
Author: samuel100 <[email protected]>
Date:   Fri May 9 14:59:58 2025 +0100

    fix pivot group id

commit 6d6f215
Merge: f4b1809 f648e4b
Author: samuel100 <[email protected]>
Date:   Fri May 9 14:52:07 2025 +0100

    Merge branch 'main' of https://github.com/samuel100/azure-ai-docs-pr into samuel100/foundry-local

commit f4b1809
Author: samuel100 <[email protected]>
Date:   Fri May 9 14:43:25 2025 +0100

    fix warnings and model name

commit dc2bd61
Author: samuel100 <[email protected]>
Date:   Fri May 9 14:09:33 2025 +0100

    fix pivot groups

commit 814f41a
Author: samuel100 <[email protected]>
Date:   Fri May 9 10:31:26 2025 +0100

    clean up, acrolinx

commit 3784d52
Merge: d8051e6 32e64eb
Author: Maanav Dalal <[email protected]>
Date:   Thu May 8 17:27:00 2025 -0700

    Merge pull request #12 from samuel100/acrolinx_fixes

    Acrolinx fixes

commit 32e64eb
Author: MaanavD <[email protected]>
Date:   Thu May 8 17:23:26 2025 -0700

    AI Linted for Acrolinx scores. Will see updates.

commit 9273f1d
Author: MaanavD <[email protected]>
Date:   Thu May 8 16:53:55 2025 -0700

    Fixed all warnings from Acrolinx.

commit d8051e6
Merge: c241047 6de4bd8
Author: Maanav Dalal <[email protected]>
Date:   Thu May 8 16:32:01 2025 -0700

    Merge pull request #11 from samuel100/adding_sdk_docs

    Adding sdk docs. Custom models / HF models are still WIP.

commit 6de4bd8
Author: MaanavD <[email protected]>
Date:   Thu May 8 15:47:08 2025 -0700

    modelid -> id

commit 8cc83fa
Author: MaanavD <[email protected]>
Date:   Thu May 8 15:40:44 2025 -0700

    Settled on a foundry manager syntax.

commit f8f1a53
Author: MaanavD <[email protected]>
Date:   Thu May 8 15:15:47 2025 -0700

    Updated samples.

commit 66f78b1
Author: MaanavD <[email protected]>
Date:   Thu May 8 14:43:32 2025 -0700

    Made models generic as api/sdk now supports that.

commit 7ae0a13
Author: MaanavD <[email protected]>
Date:   Thu May 8 14:33:34 2025 -0700

    removed another constructor.

commit fd4b213
Author: MaanavD <[email protected]>
Date:   Thu May 8 14:25:52 2025 -0700

    removed constructor.

commit 0cb7978
Author: MaanavD <[email protected]>
Date:   Thu May 8 14:20:47 2025 -0700

    Made both python and js docs aligned logically.

commit 36b6c59
Author: MaanavD <[email protected]>
Date:   Thu May 8 14:07:18 2025 -0700

    Fixed API key

commit 27dfbb6
Author: MaanavD <[email protected]>
Date:   Thu May 8 14:05:38 2025 -0700

    Updated SDK docs to reflect live SDK.

commit 7ce3b61
Author: MaanavD <[email protected]>
Date:   Tue May 6 16:53:30 2025 -0700

    Removed custom model page, made custom model tip clearer.

commit 56adf9f
Author: MaanavD <[email protected]>
Date:   Tue May 6 12:58:25 2025 -0700

    Fixed more ai foundry local -> foundry local. how to models is still WIP.

commit 66140d1
Author: MaanavD <[email protected]>
Date:   Tue May 6 12:55:47 2025 -0700

    added sdk docs

commit 127cefc
Author: MaanavD <[email protected]>
Date:   Tue May 6 12:55:21 2025 -0700

    added reference to SDK in the Foundry Local docs.

commit c241047
Author: Maanav Dalal <[email protected]>
Date:   Tue May 6 12:39:20 2025 -0700

    Fixing catalog instances of ai foundry local (#10)

    * All AI Foundry Local -> Foundry Local.

    * All ai-foundry-local files -> foundry-local

commit 4d68121
Merge: 06d8c3d 4967f31
Author: Nat Kershaw (MSFT) <[email protected]>
Date:   Mon May 5 14:19:43 2025 -0700

    Merge pull request #9 from samuel100/fixing_catalog

    Fixing catalog

commit 4967f31
Author: MaanavD <[email protected]>
Date:   Mon May 5 14:14:59 2025 -0700

    Fixed catalog issues, made auth only anonymous.

commit 06d8c3d
Merge: 0efb824 4484331
Author: Maanav Dalal <[email protected]>
Date:   Mon May 5 13:17:44 2025 -0700

    Merge pull request #8 from samuel100/custom_models

    Changed ToC a bit, added catalog api reference.

commit 4484331
Author: Maanav Dalal <[email protected]>
Date:   Mon May 5 13:16:26 2025 -0700

    Update articles/ai-foundry-local/reference/reference-catalog-api.md

    Co-authored-by: Nat Kershaw (MSFT) <[email protected]>

commit 77da9bc
Author: Maanav Dalal <[email protected]>
Date:   Mon May 5 13:16:17 2025 -0700

    Update articles/ai-foundry-local/reference/reference-catalog-api.md

    Co-authored-by: Nat Kershaw (MSFT) <[email protected]>

commit 9fe338f
Author: Maanav Dalal <[email protected]>
Date:   Mon May 5 13:16:10 2025 -0700

    Update articles/ai-foundry-local/reference/reference-catalog-api.md

    Co-authored-by: Nat Kershaw (MSFT) <[email protected]>

commit e3a1134
Author: Maanav Dalal <[email protected]>
Date:   Mon May 5 13:16:00 2025 -0700

    Update articles/ai-foundry-local/reference/reference-catalog-api.md

    Co-authored-by: Nat Kershaw (MSFT) <[email protected]>

commit 66475dc
Author: Maanav Dalal <[email protected]>
Date:   Mon May 5 13:15:52 2025 -0700

    Update articles/ai-foundry-local/reference/reference-catalog-api.md

    Co-authored-by: Nat Kershaw (MSFT) <[email protected]>

commit 2d59ded
Author: MaanavD <[email protected]>
Date:   Fri May 2 11:45:19 2025 -0700

    Changed ToC a bit, added catalog api reference.

commit 0efb824
Author: Elena Neroslavskaya <[email protected]>
Date:   Wed Apr 23 13:04:35 2025 -0700

    Restore LangChain tutorial for AI Foundry Local

commit 9843707
Author: Elena Neroslavskaya <[email protected]>
Date:   Wed Apr 23 13:02:08 2025 -0700

    Add LangChain tutorial for AI Foundry Local

commit 212a9be
Author: Elena Neroslavskaya <[email protected]>
Date:   Wed Apr 23 15:48:58 2025 -0400

    Rename use-langchain-with-foundrylocal to use-langchain-with-foundrylocal.md

commit d77dfb5
Author: Elena Neroslavskaya <[email protected]>
Date:   Wed Apr 23 15:48:29 2025 -0400

    Create use-langchain-with-foundrylocal

    LAngchain example

commit 2b0877c
Author: Maanav Dalal <[email protected]>
Date:   Mon Apr 7 12:48:39 2025 -0700

    added api docs w/ warning. (#6)

commit 707e248
Author: Maanav Dalal <[email protected]>
Date:   Tue Apr 1 06:14:30 2025 -0700

    Modified get started based on Jon's feedback, moved cli commands to reference. (#5)

commit 2175f87
Author: Maanav Dalal <[email protected]>
Date:   Tue Apr 1 06:13:53 2025 -0700

    Update toc for legibility. (#4)

commit 4bc4b89
Author: samuel100 <[email protected]>
Date:   Tue Mar 25 14:36:09 2025 +0000

    added step to create inference_model.json file

commit a2ff330
Author: Maanav Dalal <[email protected]>
Date:   Tue Mar 25 02:37:10 2025 -0700

    Hf model docs + Open web UI tutorial (minus images and /v1/models endpoint). (#3)

    * Updated hf model docs + changed name slightly.

    * Made entry more user friendly.

    * Added open webui example. ONLY WORKS IF /v1/models ENDPOINT IS FIXED.

commit d1d1457
Author: samuel100 <[email protected]>
Date:   Sat Mar 22 17:10:17 2025 +0000

    architecture doc added

commit 1801653
Author: samuel100 <[email protected]>
Date:   Sat Mar 22 16:00:33 2025 +0000

    get started update

commit b4a22ff
Author: samuel100 <[email protected]>
Date:   Sat Mar 22 15:46:12 2025 +0000

    referenced the integrate SDK article.

commit fe6de37
Author: samuel100 <[email protected]>
Date:   Sat Mar 22 15:28:48 2025 +0000

    resolved file not found issue

commit 95afea3
Author: samuel100 <[email protected]>
Date:   Sat Mar 22 15:09:26 2025 +0000

    fixed pivot issue. Change curl to REST for consistency.

commit 65221e1
Author: samuel100 <[email protected]>
Date:   Sat Mar 22 14:45:22 2025 +0000

    fix zone pivot group issue

commit eddd4bc
Author: Maanav Dalal <[email protected]>
Date:   Sat Mar 22 07:35:18 2025 -0700

    Install and inference (#2)

    * Installation already existent, added 5 inference examples.

    * added curl example.

    * Made curl work, moved streaming to stream.

    * attempted adding pivots. Will have to see if it worked in PR.

commit 253ca32
Author: samuel100 <[email protected]>
Date:   Fri Mar 21 18:02:32 2025 +0000

    included examples of using REST and OpenAI SDK

commit 8f1f332
Author: samuel100 <[email protected]>
Date:   Fri Mar 21 17:33:17 2025 +0000

    changed commands to tables

commit c736a17
Author: samuel100 <[email protected]>
Date:   Thu Mar 20 10:33:49 2025 +0000

    changed qucikstars to tutorials

commit 3d249b7
Author: samuel100 <[email protected]>
Date:   Thu Mar 20 10:19:09 2025 +0000

    fixed up acrolinx

commit fe1d468
Merge: 60ca2ed 22a3bd2
Author: Samuel Kemp <[email protected]>
Date:   Thu Mar 20 10:11:32 2025 +0000

    Merge pull request #1 from MaanavD/info_and_quickstart

    Info and quickstart

commit 22a3bd2
Author: MaanavD <[email protected]>
Date:   Thu Mar 20 01:06:38 2025 -0700

    Added Quickstart and what is ai foundry.

commit 60ca2ed
Author: samuel100 <[email protected]>
Date:   Wed Mar 19 21:47:25 2025 +0000

    fix typo

commit 9e20631
Author: samuel100 <[email protected]>
Date:   Wed Mar 19 18:50:38 2025 +0000

    fix acrolinx issues

commit f9c8f57
Author: samuel100 <[email protected]>
Date:   Wed Mar 19 18:34:09 2025 +0000

    compile models using olive doc

commit a2db4ba
Author: samuel100 <[email protected]>
Date:   Wed Mar 19 14:11:45 2025 +0000

    fix warning

commit f2f2312
Author: samuel100 <[email protected]>
Date:   Wed Mar 19 14:05:47 2025 +0000

    added reference doc placeholders.

commit f6821c9
Author: samuel100 <[email protected]>
Date:   Tue Mar 18 14:19:16 2025 +0000

    foundry local init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-urban eric-urban Awaiting requested review from eric-urban

Assignees

@eric-urban eric-urban

Labels
aq-pr-triaged C+L Pull Request Review Team label azure-ai-speech/svc Change sent to author do-not-merge qualifies-for-auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kefaslungu @Court72 @v-dirichards @v-ccolin @eric-urban