Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network-requirements.md #7

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edyoung
Copy link
Contributor

@edyoung edyoung commented Oct 1, 2024

Not for merging just yet. Needs some additional rollouts and validation.

Not for merging just yet. Needs some additional rollouts and validation.
Copy link
Contributor

@edyoung : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 8150436:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/azure-arc/servers/includes/network-requirements.md ⚠️Warning Details

articles/azure-arc/servers/includes/network-requirements.md

  • Line 84, Column 73: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/governance/machine-configuration/overview#network-requirements' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 84, Column 73: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/governance/machine-configuration/overview#network-requirements' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Oct 1, 2024

@johnmarco

When this PR is marked ready for review, can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Oct 1, 2024
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged C+L Pull Request Review Team label azure-arc/svc azure-arc-servers/subsvc Change sent to author do-not-merge inactive This PR is inactive for more than 14 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants