Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Import browser data" - When your imported data is sent to Microsoft #2934

Merged
merged 10 commits into from
Dec 13, 2023

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Nov 20, 2023

Rendered article section for review:

Public rendered preview (approx layout):
https://github.com/MicrosoftDocs/edge-developer/blob/user/mikehoffms/import-data/microsoft-edge/privacy-whitepaper/index.md#import-browser-data - starting at "Importing your data is completed locally", now a sep. para. leading into two list items.

Internal private preview (full layout); requires linked GitHub account per Create and configure a GitHub account -
https://review.learn.microsoft.com/microsoft-edge/privacy-whitepaper/?branch=pr-en-us-2934#import-browser-data - starting at "Importing your data is completed locally", now a sep. para. leading into two list items.

AB#47778992

Copy link

@amatharoo1459 amatharoo1459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed text and links.

@mikehoffms
Copy link
Collaborator Author

This PR LGTM.

@mikehoffms mikehoffms changed the title When your imported data is sent to Microsoft Update "Import browser data" - When your imported data is sent to Microsoft Nov 22, 2023
Copy link
Contributor

@chgangwa chgangwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@apryzgoda apryzgoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke with Andrea Chin to confirm support. Please remove the word "secure" from line 443. After that I will approve this.

Copy link
Contributor

@apryzgoda apryzgoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge Privacy Champ Approved

Copy link

Learn Build status updates of commit 02ceb43:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/privacy-whitepaper/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 58b4988:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/privacy-whitepaper/index.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Reezaali Reezaali merged commit 711c1fe into main Dec 13, 2023
@Reezaali Reezaali deleted the user/mikehoffms/import-data branch December 13, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants