Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and clarify the memory terminology article #3033

Merged
merged 16 commits into from
Feb 5, 2024

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Jan 24, 2024

Rendered articles for review:

These articles are a bit hard to understand, sometimes give information that's not really actionable for web developers, and could use an update.

AB#48649923

@captainbrosset captainbrosset added the cat: devtools DevTools-related content. label Jan 24, 2024
@captainbrosset captainbrosset marked this pull request as ready for review January 30, 2024 15:00
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st-pass review of heap-snapshots.md
3rd-pass review of memory-101.md

Copy link

@sethbrenith sethbrenith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor comments.

Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR, per Writer/Editor reviews/revisions.

Copy link

Learn Build status updates of commit dc711be:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/clear-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/closure-retained-strings.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/closure-retained-strings-details.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/filters-retainers-memory-tool-no-hide-cycled.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/heap-snapshots.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/heap-snapshots-all.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/heap-snapshots-all-hover-clear-all-profiles.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/heap-snapshots-comparison-dropdown.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/heap-snapshots-constructor-highlight.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/heap-snapshots-constructor-retainers.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/heap-snapshots-containment-dropdown.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/heap-snapshots-view-dropdown.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/memory-problems-tree-gc.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/more-tools-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/node-types-heap-snapshot.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/retainers-section.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/heap-snapshots-images/take-another-snapshot.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/memory-101.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/memory-problems/memory-101-images/dominators-00.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/memory-problems/memory-101-images/dominators-01.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/memory-problems/memory-101-images/dominators-02.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/memory-problems/memory-101-images/dominators-03.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/memory-problems/memory-101-images/dominators-04.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/memory-problems/memory-101-images/dominators-05.png ✅Succeeded n/a (file deleted or renamed)

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit 88571ab into main Feb 5, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/pabrosse/mem-term branch February 5, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants