Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note about file path source maps and some cleanup #3040

Merged
merged 9 commits into from
Feb 6, 2024

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Jan 29, 2024

Rendered articles for review:

This PR adds a short section about a new preference that needs to be enabled when using file path source maps.

The PR also contains some general updating of the source maps article, including moving out the sourceURL section that doesn't have anything to do with the source maps. I moved this section to the reference article instead.

This PR fixes #3019.

AB#48735772

@captainbrosset captainbrosset added the cat: devtools DevTools-related content. label Jan 29, 2024
Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

started Writer/Editor review

Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entered comments for Writer/Review pass.

Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entered comments, as a probably final Writer/Editor review pass

Copy link

Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved per Writer/Editor review

@captainbrosset captainbrosset merged commit deb4dd6 into main Feb 6, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/pabrosse/enable-source-map branch February 6, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Screenshot and text for Step 1 is now out of date
2 participants