Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the JSON viewer's Search/Find UI #3060

Merged
merged 12 commits into from
Apr 9, 2024

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Feb 14, 2024

Rendered article section for review:

AB#49007933

@mikehoffms mikehoffms added cat: devtools DevTools-related content. in-progress labels Feb 15, 2024
@captainbrosset captainbrosset marked this pull request as ready for review April 8, 2024 15:15
Copy link
Collaborator Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; virtually approved PR (I'm the owner) after pushing commits for a Writer/Editor review.

Copy link

Learn Build status updates of commit 8c5ce3f:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer-images/search.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer-images/search-modes.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer-images/search-move.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@hkal
Copy link

hkal commented Apr 8, 2024

@captainbrosset - LGTM

@captainbrosset captainbrosset merged commit adac010 into main Apr 9, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/json-search branch April 9, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants