Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ms.service: issues found in content engagement report #3062

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

msangapu-msft
Copy link
Contributor

@msangapu-msft msangapu-msft commented Feb 15, 2024

AB#49023826

@mikehoffms mikehoffms added the cat: devtools DevTools-related content. label Feb 15, 2024
@msangapu-msft
Copy link
Contributor Author

msangapu-msft commented Feb 15, 2024

@Reezaali can you please merge this? it's affecting our content engagement data for App Service.

@mikehoffms
Copy link
Collaborator

mikehoffms commented Feb 15, 2024

full-text search of repo on "ms.service:" reveals two instances to fix: docset landing page & devtools landing page. Then, all files will have same value (along w/ a valid value for ms.subservice if present/applicable). Pushed commits.

@msangapu-msft
Copy link
Contributor Author

msangapu-msft commented Feb 15, 2024

full-text search of repo on "ms.service:" reveals two instances to fix: docset landing page & devtools landing page. Then, all files will have same value (along w/ a valid value for ms.subservice if present/applicable). Pushed commits.

Thank you @mikehoffms

Copy link

Learn Build status updates of commit 1f7b8e9:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/developer/index.yml ✅Succeeded View
microsoft-edge/devtools-guide-chromium/landing/index.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the PR, after checked valid values for ms.service: & ms.subservice:, for hub page (ok) & the two landing pages (fixed).

@mikehoffms mikehoffms changed the title fix issues found in content engagement report fix ms.service: issues found in content engagement report Feb 15, 2024
@mikehoffms mikehoffms changed the title fix ms.service: issues found in content engagement report Fix ms.service: issues found in content engagement report Feb 15, 2024
@captainbrosset captainbrosset merged commit 32b2d64 into MicrosoftDocs:main Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants