Update to httpCompression attributes #273
Conversation
|
ping @bangbingsyb |
| | [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. | | ||
| | [`staticTypes`](statictypes/index.md) | Optional element. <br><br>Specifies configuration settings for static compression. | | ||
| | [`scheme`](scheme.md) | Optional element. <br><br>Specifies the compression scheme (Gzip or Deflate) IIS uses to compress client requests. This element can only be configured at server level. | | ||
| | [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. This element can be configured at site level. | |
There was a problem hiding this comment.
Many thanks for making the change for us!
Minor change requested: In fact, dynamicTypes and staticTypes are only allowed to be configured at site level since IIS 10.0 and above. Before IIS 10.0, they can only be configured at server level.
There was a problem hiding this comment.
@bangbingsyb use the suggestion mechanism so I can accept your suggestion, then I'll S&M this PR.
|
@remcoeissing please review. |
| @@ -207,8 +207,8 @@ These attributes can only be configured at server level. Configuration at a site | |||
| | Element | Description | | |||
| | --- | --- | | |||
| | [`scheme`](scheme.md) | Optional element. <br><br>Specifies the compression scheme (Gzip or Deflate) IIS uses to compress client requests. This element can only be configured at server level. | | |||
| | [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. This element can be configured at site level. | | |||
| | [`staticTypes`](statictypes/index.md) | Optional element. <br><br>Specifies configuration settings for static compression. This element can be configured at site level. | | |||
| | [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. For IIS 10.0 and later, can only be configured at the site level. Versions prior to IIS 10.0, can only be configured at the server level. | | |||
There was a problem hiding this comment.
I think this sentence "For IIS 10.0 and later, can only be configured at the site level. Versions prior to IIS 10.0, can only be configured at the server level" indicates that dynamicTypes settings cannot be used at server level on IIS 10+. That's not correct and even default IIS 10 configuration file contains dynamicTypes at server level.
I suggest we change it to "For IIS versions prior to IIS 10.0, can only be configured at the server level. For IIS 10.0 and later, can also be configured at the site level."
| | [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. This element can be configured at site level. | | ||
| | [`staticTypes`](statictypes/index.md) | Optional element. <br><br>Specifies configuration settings for static compression. This element can be configured at site level. | | ||
| | [`dynamicTypes`](dynamictypes/index.md) | Optional element. <br><br>Specifies configuration settings for dynamic compression. For IIS 10.0 and later, can only be configured at the site level. Versions prior to IIS 10.0, can only be configured at the server level. | | ||
| | [`staticTypes`](statictypes/index.md) | Optional element. <br><br>Specifies configuration settings for static compression. For IIS 10.0 and later, can only be configured at the site level. Versions prior to IIS 10.0, can only be configured at the server level. | |
There was a problem hiding this comment.
Similarly, here we should say "For IIS versions prior to IIS 10.0, can only be configured at the server level. For IIS 10.0 and later, can also be configured at the site level."
|
@Rick-Anderson @remcoeissing I added two new comments. |
Rick-Anderson
requested review from
lextm and
wadepickett
and removed request for
lextm
|
I started to make some very minor edits but then reverted them. I thought I spotted a lextm's change that hadn't been pulled in yet, and received an odd server error, so backed out. Was just updating the ms.date, nothing crucial. |
Update to how elements and attributes of httpCompression work.