Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked zh_cn translation #3728

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

HfSrJun
Copy link
Contributor

@HfSrJun HfSrJun commented Jul 27, 2024

zh_cn translation of this mod is in bad quality and missing some contents, so I renewed it last year, and now I am PRing it to github.
This translation has already accepted by GTNH's fork of OC, and passed the strict review from the Chinese translation team of GTNH, so don't worry about the quality. I also uploaded it to CFPA(the biggest 3rd-party mc mod translation community in China), but it is still under reviewing by now (because of the lack of reviewers).
Further more, I finished most of the Chinese translation of official wiki.

Copy link
Contributor Author

@HfSrJun HfSrJun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only uploaded files for 1.12.2, please copy them to other versions like 1.7.10, I believe nothing changed between these to versions (but sticky piston upgrade?)
If files for 1.7.10 is also needed please comment, I will start another PR.

@mckuhei
Copy link

mckuhei commented Aug 8, 2024

Good job

@asiekierka asiekierka merged commit d69b428 into MightyPirates:master-MC1.12 Sep 21, 2024
asiekierka added a commit that referenced this pull request Sep 21, 2024
asiekierka added a commit that referenced this pull request Sep 21, 2024
@asiekierka
Copy link
Contributor

asiekierka commented Sep 21, 2024

I merged it, but it appears GT:NH uses a different translation upstream. Our 1.7.10 documentation/language files differ to some extent (for example, all the language key names are different, all the filenames are different due to post-1.7 engine changes, some text is also different); this means I can't easily adapt this back to 1.7.10.

As such, I've reverted it and would like to see a 1.7.10 pull request as well if this is to be merged; note, however, that the mod is not exactly maintained anymore (beyond urgent fixes)...

@HfSrJun
Copy link
Contributor Author

HfSrJun commented Sep 21, 2024

I merged it, but it appears GT:NH uses a different translation upstream. Our 1.7.10 documentation/language files differ to some extent (for example, all the language key names are different, all the filenames are different due to post-1.7 engine changes, some text is also different); this means I can't easily adapt this back to 1.7.10.

As such, I've reverted it and would like to see a 1.7.10 pull request as well if this is to be merged; note, however, that the mod is not exactly maintained anymore (beyond urgent fixes)...

Actually I do noticed the difference between GTNH port and the official stream, and handled them properly. I will make a new PR the satisfy the 1.7.10 formation, do I need PR the 1.12.2 version again? Please let me know.

@asiekierka
Copy link
Contributor

You don't. But I can't promise it will be merged soon; as I said, I only spin new OpenComputers versions when new security issues arise these days...

@HfSrJun
Copy link
Contributor Author

HfSrJun commented Sep 21, 2024

You don't. But I can't promise it will be merged soon; as I said, I only spin new OpenComputers versions when new security issues arise these days...

1.7.10 PR had submitted(#3737), and I resubmitted the 1.12.2 one in order to fix some minor mistakes and make updating easier(with out revert, just merge #3738). Please merge them when next update coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants