fix: Enforce task author immutability upon modification#38
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request addresses a data integrity vulnerability where editing an existing task could potentially alter or clear its original author. It ensures that the task's ownership remains strictly immutable during a POST form submission, blocking any external attempt to falsify or wipe out data ownership.
Changes Made
1. Form Protection (
src/AppBundle/Form/TaskType.php)userorauthorfield is exposed or modifiable by the client during edition.2. Controller Security (
src/AppBundle/Controller/TaskController.php)editAction()to snapshot the$originalAuthorreference before handling the request payload.$task->setUser($originalAuthor)), making the property fully tamper-proof.3. Functional Testing (
tests/AppBundle/Controller/TaskControllerTest.php)testEditTaskUserRemainsImmutable()using HTTP Basic Auth.POSTrequest, flushes/clears the Doctrine identity map, and asserts via database IDs that the title was updated while the user relation remained untouched.How to Test / Review
git checkout fix/task-author-immutable