Feat/user-roles : Implement user role selection with CallbackTransformer#40
Merged
Conversation
…tion - Add unique constraints for username and email on the User entity. - Document User entity properties and methods with clean PHPDocs. - Integrate role selection in UserType with an expanded ChoiceType (radio buttons). - Use a CallbackTransformer in UserType to handle seamless translation between the form's single choice string and the entity's roles array. - Refactor UserController to ensure form submission safety and prevent password erasure when editing users. Resolves #10
…ding in assertions - Change DomCrawler selection for 'user[roles]' from array format to a single string value to prevent InvalidArgumentException in ChoiceFormField. - Resolve PHPUnit assertion failure by adjusting expected flash message string to match HTML-encoded apostrophe (L'utilisateur). - All 7 PHPUnit tests are now successfully passing.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 4 medium |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the explicit selection of user roles (User vs. Administrator) during user creation and edition, as specified in the project requirements.
To achieve a clean architecture and prevent controller bloating, we implemented a form-level
CallbackTransformerto seamlessly translate the user interface's single-choice selection into the array structure expected by Symfony's Security component.Changes Checklist
@var,@param,@return) toUserclass properties and methods for better static analysis.ChoiceType(radio buttons) intoUserTypewithmultiple => falseto allow selecting exactly one role.CallbackTransformerto map the single string value from the UI to the underlyingrolesarray format, and vice-versa.UserControlleractions with$form->isSubmitted()checks and added safety logic to prevent password erasure when updating other profile fields.UserTest.php) and functional tests (UserControllerTest.php) ensuring credentials updates propagate properly in the database.Test Results
All 7 tests are now passing green: