Feat/security Allow Admins to Delete Anonymous Tasks (#13)#43
Merged
Conversation
…asks belong to User anonymous
- TaskVoter: implemented check allowing ROLE_ADMIN to delete tasks owned by 'anonyme' or null - list.html.twig: updated UI to conditionally display the delete button for anonymous tasks - TaskControllerTest: added functional test scenarios for both ROLE_USER and ROLE_ADMIN
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #13 by updating the authorization rules to allow administrators (
ROLE_ADMIN) to delete tasks that are assigned to the "anonymous" user.Changes Implemented
1. Authorization Logic (
TaskVoter.php)canDeletemethod to check if the task's author isnullor namedanonyme.AccessDecisionManagerInterfaceto authorize the deletion if the logged-in user has theROLE_ADMINrole in these specific scenarios.2. User Interface (
list.html.twig)3. Automated Tests (
TaskControllerTest.php)ROLE_USERcannot see the delete button or delete an anonymous task (expects403 Forbidden).ROLE_ADMINcan see the delete button and successfully delete an anonymous task.Acceptance Criteria Checklist
User is AuthorOR (Task is AnonymousANDUser is Admin).ROLE_USER(denied) andROLE_ADMIN(allowed) behaviors.How to Test
Close #13