Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Add Densepose (TorchScript)" #2459

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

huchenlei
Copy link
Collaborator

Reverts #2457

@RGX650
Copy link

RGX650 commented Jan 12, 2024

@huchenlei huchenlei marked this pull request as ready for review January 12, 2024 02:09
@huchenlei huchenlei merged commit eaa18bb into main Jan 12, 2024
2 checks passed
@huchenlei huchenlei deleted the revert-2457-revert-2314-densepose branch January 14, 2024 04:51
@theclashoftitans
Copy link

This preprocessor is placed under OpenPose, but I don't see a corresponding model. Is the model file missing for this preprocessor?

When I set the Preprocessor to "densepose (pruple bg & purple torso)" or "densepose_parula (black bg & blue torso)" and leave Model empty, nothing happens (obviously), and the preprocessor doesn't make an attempt to download a model file.

@huchenlei
Copy link
Collaborator Author

See original PR: #2314. There are 2 models that you can download.

@theclashoftitans
Copy link

Thanks, but this is quite confusing as a user.

  1. Shouldn't this either be documented properly, maybe in the README.md or wiki? Asking users to dig into merged PRs for each functionality is not user friendly.
  2. Other preprocessors that require an external model checks if the file exists already, and if not, automatically downloads the required file. Shouldn't this do the same?
  3. I downloaded and put those files under the controlnet's models directory. When I select the preprocessor, the model is not automatically selected, again a behavior that is different from other preprocessors.

@theclashoftitans
Copy link

I did some tests. The CivitAI model works with the parula preprocessor (I selected the model manually; I had to change the category from OpenPose to All to do that since it doesn't show up in OpenPose). However, "viridis" model with "densepose (pruple bg & purple torso)" gives completely irrelevant results.

Are you sure the following link is the correct model corresponding to the ""densepose (pruple bg & purple torso)"" preprocessor? https://huggingface.co/zcxu-eric/MagicAnimate/blob/main/densepose_controlnet/diffusion_pytorch_model.safetensors

@huchenlei
Copy link
Collaborator Author

huchenlei commented Jan 17, 2024

Well. I did not draft the PR nor did I do any testing on the model listed. You probably want to ask initial PR author @Fannovel16.

This reland PR only does the fix on unload model error.

@sdbds
Copy link
Collaborator

sdbds commented Jan 18, 2024

I did some tests. The CivitAI model works with the parula preprocessor (I selected the model manually; I had to change the category from OpenPose to All to do that since it doesn't show up in OpenPose). However, "viridis" model with "densepose (pruple bg & purple torso)" gives completely irrelevant results.

Are you sure the following link is the correct model corresponding to the ""densepose (pruple bg & purple torso)"" preprocessor? https://huggingface.co/zcxu-eric/MagicAnimate/blob/main/densepose_controlnet/diffusion_pytorch_model.safetensors

this is another video model to use,not controlnet model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants