Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small formatting fixes (no code changes) #139

Closed
wants to merge 10 commits into from
Closed

Small formatting fixes (no code changes) #139

wants to merge 10 commits into from

Conversation

Jack1424
Copy link

Similar to what I did with the main Vault repository, I did some grammar fixes and updated some links. I also fixed some indentation and spacing in configuration files and made tiny improvements to the publish script.

@Jack1424
Copy link
Author

Jack1424 commented Jun 28, 2022

Also, I noticed that you used version 1.7 in the Maven and Gradle implementation examples even though 1.7.1 is available. I didn't know if I should change it, since it seems like Vault API should only be major.minor, unlike the Vault plugin. However, 1.7.1 is available in the repository.

README.md Show resolved Hide resolved
@Geolykt
Copy link
Contributor

Geolykt commented Jun 28, 2022

I'd wait till #138 gets merged until doing any changes

@Jack1424
Copy link
Author

That's what I was thinking

@Jack1424 Jack1424 changed the title Small formatting fixes Small formatting fixes (no code changes) Jul 2, 2022
@Jack1424 Jack1424 closed this by deleting the head repository Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants