Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local filesystem storage #10

Merged
merged 12 commits into from
Oct 31, 2023
Merged

Local filesystem storage #10

merged 12 commits into from
Oct 31, 2023

Conversation

piotr-iohk
Copy link
Collaborator

Following with the changes from #9, this pr introduces local filesystem storage implementation in delegation_backend package.

Overview

  • uptime-service-backend operator may use local filesystem as storage backend by adding to the app_config.json:
  "filesystem": {
    "path": "/path/to/local/dir"
  }

Testing

  • there was an integration test added that is testing if blocks and submissions are stored on local filesystem in case if app_config.json contains local filesystem config.

@piotr-iohk piotr-iohk self-assigned this Oct 30, 2023
@piotr-iohk piotr-iohk force-pushed the local-filesystem-storage branch 2 times, most recently from c3afaba to 4e7eb0b Compare October 30, 2023 17:32
@piotr-iohk piotr-iohk force-pushed the local-filesystem-storage branch from 1476687 to c99d560 Compare October 31, 2023 10:46
Copy link
Contributor

@Smorci Smorci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major, just some minor comments.

src/integration_tests/constants.go Outdated Show resolved Hide resolved
src/integration_tests/integration_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Sventimir Sventimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

Copy link
Contributor

@Smorci Smorci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@piotr-iohk piotr-iohk merged commit f7a5575 into main Oct 31, 2023
2 checks passed
@piotr-iohk piotr-iohk deleted the local-filesystem-storage branch October 31, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants