Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PM-396 - Db storage amazon keyspaces (cassandra) #13

Merged
merged 17 commits into from
Nov 8, 2023
Merged

PM-396 - Db storage amazon keyspaces (cassandra) #13

merged 17 commits into from
Nov 8, 2023

Conversation

piotr-iohk
Copy link
Collaborator

@piotr-iohk piotr-iohk commented Nov 3, 2023 •
edited
Loading

This PR:

  • provides option to store blocks and submissions in AWS Keyspaces Cassandra database
  • provides migration scripts to create database make db-migrate-up and make db-migrate-down
  • adds integration test checking that program successfuly saves data to AWS Keyspaces Cassandra database
  • documents configuration of aws keyspaces backend (also providing missing documentation about other configs AWS S3 and local filesystem)

@piotr-iohk piotr-iohk self-assigned this Nov 6, 2023
@piotr-iohk piotr-iohk marked this pull request as ready for review November 6, 2023 16:30
@piotr-iohk piotr-iohk changed the title Db storage amazon keyspaces (cassandra) PM-396 - Db storage amazon keyspaces (cassandra) Nov 7, 2023
Sventimir
Sventimir approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@Sventimir Sventimir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Just some minor remarks below.

database/cert/sf-class2-root.crt Show resolved Hide resolved
database/migrations/1_create_submissions_table.up.cql Show resolved Hide resolved
database/migrations/2_create_blocks_table.up.cql Outdated Show resolved Hide resolved
@piotr-iohk piotr-iohk requested a review from ejMina226 November 8, 2023 10:24
Smorci
Smorci reviewed Nov 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
database/cert/sf-class2-root.crt Show resolved Hide resolved
database/migrations/1_create_submissions_table.down.cql Outdated Show resolved Hide resolved
src/delegation_backend/app_config.go Outdated Show resolved Hide resolved
@piotr-iohk piotr-iohk force-pushed the db_storage_amazon_keyspaces branch from 59903a9 to 50e62f0 Compare November 8, 2023 14:12
@piotr-iohk piotr-iohk merged commit 69a5035 into main Nov 8, 2023
2 checks passed
@piotr-iohk piotr-iohk deleted the db_storage_amazon_keyspaces branch November 8, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smorci Smorci Smorci left review comments

@Sventimir Sventimir Sventimir approved these changes

@ejMina226 ejMina226 Awaiting requested review from ejMina226

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-iohk @Sventimir @Smorci