Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test #7

Merged
merged 14 commits into from
Oct 25, 2023
Merged

Integration test #7

merged 14 commits into from
Oct 25, 2023

Conversation

piotr-iohk
Copy link
Collaborator

@piotr-iohk piotr-iohk commented Oct 18, 2023 •
edited
Loading

This pr adds simple integration test which:

  • starts uptime_service_backend within the local network (spinned up via minimina)
  • runs the network until there are blocks and submissions correctly appearing in AWS backend bucket called integration-test

@piotr-iohk piotr-iohk force-pushed the integration-test branch 9 times, most recently from c4d4992 to d528bd7 Compare October 22, 2023 19:32
@piotr-iohk piotr-iohk changed the title test minimina Integration test Oct 23, 2023
@piotr-iohk piotr-iohk self-assigned this Oct 23, 2023
@piotr-iohk piotr-iohk force-pushed the integration-test branch 2 times, most recently from 32a25f9 to 0c4d34f Compare October 23, 2023 15:45
@piotr-iohk piotr-iohk marked this pull request as ready for review October 23, 2023 16:50
@piotr-iohk piotr-iohk requested a review from joaosreis October 23, 2023 16:50
@piotr-iohk piotr-iohk force-pushed the integration-test branch 2 times, most recently from 6a23312 to dea8b95 Compare October 23, 2023 20:03
Smorci
Smorci approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@Smorci Smorci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, clean code, will take this as example in the future

.github/workflows/integration.yml Show resolved Hide resolved
@piotr-iohk piotr-iohk merged commit 3c4462b into main Oct 25, 2023
@piotr-iohk piotr-iohk deleted the integration-test branch October 25, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smorci Smorci Smorci approved these changes

@joaosreis joaosreis Awaiting requested review from joaosreis

@Sventimir Sventimir Awaiting requested review from Sventimir

@michal0mina michal0mina Awaiting requested review from michal0mina

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotr-iohk @Smorci @Sventimir