Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kimchi-bindings/wasm: stop using nightly and rm ft get_mut_unchecked #16411

Open
wants to merge 5 commits into
base: compatible
Choose a base branch
from
Open

Kimchi-bindings/wasm: stop using nightly and rm ft get_mut_unchecked #16411

wants to merge 5 commits into from

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Dec 11, 2024 •
edited
Loading

Attempt to stop using nightly for wasm.

cc @martyall

Explain your changes:
*

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dannywillems dannywillems requested a review from a team as a code owner December 11, 2024 16:43
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems force-pushed the dw/remove-feature-nightly-plonk-wasm branch from 98465d7 to f13638b Compare December 11, 2024 17:26
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems requested a review from a team as a code owner December 12, 2024 12:58
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems
Copy link
Member Author

Don't merge or approve before ef80cc4 is fixed up.

@dannywillems
Copy link
Member Author

!ci-toolchain-me

@dannywillems dannywillems force-pushed the dw/remove-feature-nightly-plonk-wasm branch from f662ce5 to 8fc90d5 Compare December 12, 2024 16:35
@dannywillems
Copy link
Member Author

!ci-build-me

1 similar comment
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems force-pushed the dw/remove-feature-nightly-plonk-wasm branch from 18b9f93 to 8fc90d5 Compare December 12, 2024 16:59
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems mentioned this pull request Dec 13, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dannywillems