Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trivial/compatible] Dune/lib: run `dune build @fmt --auto-promote #16426

Open
wants to merge 2 commits into
base: compatible
Choose a base branch
from
Open

[trivial/compatible] Dune/lib: run `dune build @fmt --auto-promote #16426

wants to merge 2 commits into from

Conversation

dannywillems
Copy link
Member

Revamping an old small PR.

Explain your changes:
*

Explain how you tested your changes:

  • cd src/lib && dune build @fmt --auto-promote

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dannywillems dannywillems requested review from a team as code owners December 16, 2024 12:23
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems changed the title Dune/lib: run `dune build @fmt --auto-promote [trivial] Dune/lib: run `dune build @fmt --auto-promote Dec 16, 2024
@dannywillems dannywillems changed the title [trivial] Dune/lib: run `dune build @fmt --auto-promote [trivial/compatible] Dune/lib: run `dune build @fmt --auto-promote Dec 16, 2024
Base automatically changed from dw/remove-old-comment-pickles-scalar-challenge to compatible December 17, 2024 11:00
@dannywillems dannywillems force-pushed the dw/run-dune-fmt-on-dune-files branch from 185cf47 to c8b0d61 Compare December 17, 2024 11:24
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems force-pushed the dw/run-dune-fmt-on-dune-files branch from c8b0d61 to 992e2b2 Compare December 18, 2024 11:55
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems force-pushed the dw/run-dune-fmt-on-dune-files branch from 992e2b2 to ea03076 Compare December 18, 2024 13:02
@dannywillems
Copy link
Member Author

!ci-build-me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@querolita querolita querolita approved these changes

@volhovm volhovm volhovm approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannywillems @volhovm @querolita