Do not use magic config file in integration tests #16441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
dkijania
force-pushed
the
dkijania/do_not_use_magic_config_in_int_tests
branch
from
e538f3b to
83711be
Compare
|
!ci-build-me |
|
!ci-nightly-me |
georgeee
reviewed
Dec 23, 2024
| ( "entrypoint.sh" | ||
| , {|#!/bin/bash | ||
| # This file is auto-generated by the local integration test framework. | ||
| # |
There was a problem hiding this comment.
I wonder, could we just provide more overrides in integration test code instead of crude removal. P.S. in a med-term we want to get rid of this config discovery in a docker image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies code which formats
entrypoint.shfile for deamon image which is used in integration tests through mina daemon puppeteer. It removes/var/lib/coda/config_{comit_hash}.jsonat the beginning as it is used as one of config layer by default. See https://github.com/MinaProtocol/mina/blob/compatible/src/lib/runtime_config/runtime_config.ml#L1728 for more details.As a result, first layer of configs is config file from genesis_ledgers/{network}.json. In berkeley case it does not have any influence since berkeley config file has only content which is completely replaced by next layer (which is created by test executive). For other networks like devnet or mainnet it is more problematic as configs contains fork section, which then prevents node to produce any block. This is blocking us from using any other image (devnet for instance)