-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor network tests #16454
refactor network tests #16454
Conversation
…ce test utils which holds all mocking utilities
!ci-build-me |
b90674b
to
78a3628
Compare
!ci-build-me |
!ci-nightly-me |
e8e1e40
to
78a3628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review in full all of the mock internals, but I assume they were just copy-pasted with adding some additional functional parameters. Changes to tests look great!
|
||
let verifier = | ||
Async.Thread_safe.block_on_async_exn (fun () -> | ||
Verifier.For_tests.default ~logger ~proof_level ~conf_dir:None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verifier.For_tests.default ~logger ~proof_level ~conf_dir:None | |
Verifier.For_tests.default ~logger ~proof_level:Full ~conf_dir:None |
And let's remove declaration verifier_full
below in this file
!ci-build-me |
011e256
to
dbc1ba0
Compare
Predecessor of #16415. Extracted mock and tests for transaction pool from transaction_pool.ml and introduced:
A few words of explanation about current split of code between mock and tests. We need to place verifier under test_module part as it fails otherwise with error:
That's why mock accepts all parameters like genesis_constants and constraint_constants