Add result builders to MultiLogger and MultiTrackers 👷
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 95.09% 95.18% +0.08%
==========================================
Files 101 101
Lines 3384 3445 +61
==========================================
+ Hits 3218 3279 +61
Misses 166 166 ☔ View full report in Codecov by Sentry. |
pedroseruca
approved these changes
Apr 15, 2024
p4checo
force-pushed
the
add-result-builders-to-multi-logger-and-multi-trackers
branch
from
7f2295e to
bfa103a
Compare
Some of our "multiplexer" instances for logging (`Log.MultiLogger`), analytics (`Analytics.MultiTracker`) and performance metrics (`PerformanceMetrics.MultiTracker`) require type erasure on the child elements to which they forward events, causing the setup to be cumbersome and not intuitive. By leveraging result builders we can make this a bit smoother to users by abstracting/automating the type erasure "dance". Furthermore, it unlocks control flow (e.g. `if/else`, `for ... in`, `if #available`) which allows more advanced setups to be defined directly in the builder. ## Changes - Add result builders to facilitate instantiating certain "multiplexer" instances, most notably the ones that require type erasure: + `Log.MultiLogger` (requires erasing to `AnyMetadataLogDestination`) + `Analytics.MultiTracker` (requires erasing to `AnyAnalyticsTracker`) + `PerformanceMetrics.MultiTracker` (doesn't require erasing) - Add relevant UTs.
p4checo
force-pushed
the
add-result-builders-to-multi-logger-and-multi-trackers
branch
from
bfa103a to
dfd5bdc
Compare
p4checo
deleted the
add-result-builders-to-multi-logger-and-multi-trackers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
Some of our "multiplexer" instances for logging (
Log.MultiLogger), analytics (Analytics.MultiTracker) and performance metrics (PerformanceMetrics.MultiTracker) require type erasure on the child elements to which they forward events, causing the setup to be cumbersome and not intuitive.By leveraging result builders we can make this a bit smoother to users by abstracting/automating the type erasure "dance". Furthermore, it unlocks control flow (e.g.
if/else,for ... in,if #available) which allows more advanced setups to be defined directly in the builder.Description
Add result builders to facilitate instantiating certain "multiplexer" instances, most notably the ones that require type erasure:
Log.MultiLogger(requires erasing toAnyMetadataLogDestination)Analytics.MultiTracker(requires erasing toAnyAnalyticsTracker)PerformanceMetrics.MultiTracker(doesn't require erasing)Add relevant UTs.