-
Notifications
You must be signed in to change notification settings - Fork 92
Added a GET: /search/suggest/user route for @user tags. #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hopeseekr
wants to merge
3
commits into
Minds:master
Choose a base branch
from
hopeseekr-contribs:usertags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| <?php | ||
| /** | ||
| * Minds Core Search API | ||
| * | ||
| * @version 2 | ||
| * @author Theodore R. Smith <[email protected]> | ||
| */ | ||
|
|
||
| namespace Minds\Controllers\api\v2\search\suggest; | ||
|
|
||
| use Minds\Core; | ||
| use Minds\Core\Di\Di; | ||
| use Minds\Interfaces; | ||
| use Minds\Api\Factory; | ||
| use Minds\Entities; | ||
|
|
||
| class user implements Interfaces\Api, Interfaces\ApiIgnorePam | ||
| { | ||
| /** | ||
| * Equivalent to HTTP GET method | ||
| * @param array $pages | ||
| * @return mixed|null | ||
| */ | ||
| public function get($pages) | ||
| { | ||
| $usernames = Entities\Repositories\UserRepository::getUsersList(); | ||
|
|
||
| // Filter by the ones that match. | ||
| if (!empty($_GET['username'])) { | ||
| $userSearch = $_GET['username']; | ||
| $usernames = array_filter($usernames, function($username) use ($userSearch) { | ||
| return strpos($username, $userSearch) === 0; | ||
| }); | ||
| } | ||
|
|
||
| return Factory::response([ | ||
| 'entities' => $usernames | ||
| ]); | ||
|
|
||
| } | ||
|
|
||
| /** | ||
| * Equivalent to HTTP POST method | ||
| * @param array $pages | ||
| * @return mixed|null | ||
| */ | ||
| public function post($pages) | ||
| { | ||
| return Factory::response([]); | ||
| } | ||
|
|
||
| /** | ||
| * Equivalent to HTTP PUT method | ||
| * @param array $pages | ||
| * @return mixed|null | ||
| */ | ||
| public function put($pages) | ||
| { | ||
| return Factory::response([]); | ||
| } | ||
|
|
||
| /** | ||
| * Equivalent to HTTP DELETE method | ||
| * @param array $pages | ||
| * @return mixed|null | ||
| */ | ||
| public function delete($pages) | ||
| { | ||
| return Factory::response([]); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace Minds\Entities\Repositories; | ||
|
|
||
| use Cassandra\Rows; | ||
| use Minds\Core; | ||
| use Minds\Core\Data\cache\abstractCacher; | ||
| use Minds\Core\Data\Cassandra\Client as Cassandra_Client; | ||
| use Minds\Core\Data\Cassandra\Prepared\Custom as Cassandra_Prep_Statement; | ||
|
|
||
| class UserRepository | ||
| { | ||
| public static function getUsersList(Cassandra_Client $cql = null): array | ||
| { | ||
| /** @var abstractCacher $cache */ | ||
| $cache = Core\Di\Di::_()->get('Cache'); | ||
|
|
||
| $usernames = $cache->get('usernames'); | ||
| if (!empty($usernames)) { | ||
| return $usernames; | ||
| } | ||
|
|
||
| $usernames = self::fetchUsernames($cql); | ||
|
|
||
| // Cache for 5 minutes. | ||
| $cache->set('usernames', $usernames, 300); | ||
|
|
||
| return $usernames; | ||
| } | ||
|
|
||
| protected static function fetchUsernames(Cassandra_Client $cql = null): array | ||
| { | ||
| /** @var Cassandra_Client $cql */ | ||
| $cql = $cql ?: Core\Di\Di::_()->get('Database\Cassandra\Cql'); | ||
| $sql = <<<SQL | ||
| SELECT value AS username FROM minds.entities WHERE column1='username' ALLOW FILTERING; | ||
| SQL; | ||
|
|
||
| $query = new Cassandra_Prep_Statement(); | ||
| $query->query($sql); | ||
|
|
||
| try { | ||
| /** @var Rows $results */ | ||
| $results = $cql->request($query); | ||
| if (empty($results)) { | ||
| return []; | ||
| } | ||
| } catch (\Exception $e) { | ||
| return []; | ||
| } | ||
|
|
||
| $usernames = []; | ||
| foreach ($results as $row) { | ||
| $usernames[] = $row['username']; | ||
| } | ||
|
|
||
| return $usernames; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if the key name needs to be a lot more ... unique ...