Skip to content

Conversation

R00tB33rMan
Copy link
Contributor

This simplifies the approach towards Folia support for EntityDetection. I've tested against Spigot, and everything appears to function as intended. As for Folia, I've made sure everything works as expected in that department as well. I've also kept the code changes to a minimum, so if you encounter anything that you question or dislike, feel free to comment!

Copy link
Member

@Phoenix616 Phoenix616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I like this approach a lot more than the other PR, I just have some things that I would like to see changed/improved but overall the approach looks good to me!

@R00tB33rMan
Copy link
Contributor Author

Thank you for your PR! I like this approach a lot more than the other PR, I just have some things that I would like to see changed/improved but overall the approach looks good to me!

Went ahead and pushed those tweaks. Think this is how it should be done anyway!

@Phoenix616
Copy link
Member

Thanks for adjusting it! I am testing and taking a look at this again locally right now and I'm going to adjust a couple things myself before merging it as I have some concerns about thread-safety on Folia in some places (and some general improvement possibilities I noticed).

@Phoenix616 Phoenix616 merged commit 4a83247 into Minebench:master Oct 11, 2025
@Phoenix616
Copy link
Member

Phoenix616 commented Oct 11, 2025

Couldn't push to your PR branch as you PRd from an organization so I merged it and added my changes in a separate commit: b17c8b0

@R00tB33rMan
Copy link
Contributor Author

Ah no problem. Thank you for cleaning this up a bit as well. Really didn’t know all of the specifics so nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants