-
-
Notifications
You must be signed in to change notification settings - Fork 12
Reconstructed Folia Support #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR! I like this approach a lot more than the other PR, I just have some things that I would like to see changed/improved but overall the approach looks good to me!
src/main/java/de/themoep/entitydetection/searcher/ChunkSearchResult.java
Outdated
Show resolved
Hide resolved
src/main/java/de/themoep/entitydetection/searcher/ChunkSearchResult.java
Outdated
Show resolved
Hide resolved
src/main/java/de/themoep/entitydetection/searcher/ChunkSearchResult.java
Outdated
Show resolved
Hide resolved
Went ahead and pushed those tweaks. Think this is how it should be done anyway! |
Thanks for adjusting it! I am testing and taking a look at this again locally right now and I'm going to adjust a couple things myself before merging it as I have some concerns about thread-safety on Folia in some places (and some general improvement possibilities I noticed). |
Couldn't push to your PR branch as you PRd from an organization so I merged it and added my changes in a separate commit: b17c8b0 |
Ah no problem. Thank you for cleaning this up a bit as well. Really didn’t know all of the specifics so nice work! |
This simplifies the approach towards Folia support for EntityDetection. I've tested against Spigot, and everything appears to function as intended. As for Folia, I've made sure everything works as expected in that department as well. I've also kept the code changes to a minimum, so if you encounter anything that you question or dislike, feel free to comment!