Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically center header elements #306

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Conversation

dkbnz
Copy link
Contributor

@dkbnz dkbnz commented Jun 24, 2023

Description

Fix vertical alignment of header elements

  • Add custom css to head
  • Use flexbox for responsive spacing

Fixes #283

Unfortunately the theme has hard-coded 45px as the header height, which is used for calculating viewports in other areas. Would need to change upstream if we'd like a bigger header.

Screenshot from 2023-06-24 17-18-26
Screenshot from 2023-06-24 17-18-01

@dkbnz dkbnz requested a review from a team as a code owner June 24, 2023 05:25
@netlify
Copy link

netlify bot commented Jun 24, 2023

Deploy Preview for minimumcd ready!

Name Link
🔨 Latest commit 6114b6a
🔍 Latest deploy log https://app.netlify.com/sites/minimumcd/deploys/649a16b09ab9b00008d0dd4c
😎 Deploy Preview https://deploy-preview-306--minimumcd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@bdfinst bdfinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Can you also add yourself as a contributor?

bdfinst
bdfinst previously approved these changes Jun 26, 2023
@bdfinst bdfinst merged commit b2614e9 into Minimum-CD:master Jun 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] - Should the header have consistent vertical alignment?
2 participants