Modernize the library so it works with modern node without hacks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library was built a few years ago when modules weren't as easy to work with in node as they are today, especially in node 14. This PR updates the build and testing logic so we can finally use the modern versions of node without any ESM shenanigans. It should be a lot easier to use and test, and somewhat faster to run on modern node. Also updated codecov and its badge so we get the modern coverage with the correct uploader. V1 has been disabled for more than a year now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library was built a few years ago when modules weren't as easy to work with in node as they are today, especially in node 14. This PR updates the build and testing logic so we can finally use the modern versions of node without any ESM shenanigans. It should be a lot easier to use and test, and somewhat faster to run on modern node.
Also updated codecov and its badge so we get the modern coverage with the correct uploader. V1 has been disabled for more than a year now.