2749 ollama client auth token #3005
Open
+199
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sensible fallback to not break existing installs re-order of input fields null-check for API key and header optional insert on request linting
|
@timothycarambat, thank you for reviewing this, the workspace chat fails because there is a dependency conflict with current ollama-js version 5.0, it does not pass headers while creating a completion. The latest version with header support is 5.10.0, attaching screenshots. Workspace chat after upgrading works as expected. Pushed the changes.
|
|
Excellent catch, I had only tested on my local Ollama to make sure current integrations work without a header since that is the normal and majority use case. i hadn't done a full QA yet, so thanks for catching that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
What is in this change?
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes