Set direction depending on the active locale + update Translation #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ adapt style,modals css + add translations keys + Arabic translation update
|
Hello, |
|
This is such a fundamentally massive change that contributes a ton of inline conditional CSS that will be very tricky to maintain + QA through the app. There is an easier way to accomplish this kind of behavior app-wide without having the inline every element with CSS. Closing this as we wont merge this, but please make an open issue for this as we wont merge PRs that dont have issues anyway since they dont track changes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #xxx
What is in this change?
Set the document direction depending on the active locale (ltl rtl ) + adapt style,modals css + add translations keys + Arabic translation update
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes