polish(console): drop tz note, BenzoNet-locked network indicator, full-width search#55
Conversation
…ng with the date input), lock the console to the BenzoNet L1 with a read-only network indicator (no broken switcher), and let the search bar fill the top-bar width
📝 WalkthroughWalkthroughThe console now defaults to BenzoNet, shows a read-only build-configured network indicator, and updates command bar, header, explorer test, and audit filter layouts. ChangesNetwork configuration and indicator
Console layout adjustments
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
| <button | ||
| onClick={() => setOpen(true)} | ||
| className="flex h-[34px] w-[300px] flex-none items-center gap-2 whitespace-nowrap rounded-[9px] border border-border bg-bg px-3 text-[13px] text-[#9a9ea3] outline-none transition hover:border-[#cfd2cc] focus-visible:border-primary focus-visible:ring-2 focus-visible:ring-primary/20" | ||
| className="flex h-[34px] w-full flex-1 min-w-0 items-center gap-2 whitespace-nowrap rounded-[9px] border border-border bg-bg px-3 text-[13px] text-[#9a9ea3] outline-none transition hover:border-[#cfd2cc] focus-visible:border-primary focus-visible:ring-2 focus-visible:ring-primary/20" |
There was a problem hiding this comment.
w-full is redundant alongside flex-1 in a flex context. flex-1 min-w-0 is sufficient — the initial flex-basis: 0% from flex-1 already drives the growth, and w-full can cause the element to briefly claim 100% width before flex distribution kicks in. Removing w-full is cleaner.
| className="flex h-[34px] w-full flex-1 min-w-0 items-center gap-2 whitespace-nowrap rounded-[9px] border border-border bg-bg px-3 text-[13px] text-[#9a9ea3] outline-none transition hover:border-[#cfd2cc] focus-visible:border-primary focus-visible:ring-2 focus-visible:ring-primary/20" | |
| className="flex h-[34px] flex-1 min-w-0 items-center gap-2 whitespace-nowrap rounded-[9px] border border-border bg-bg px-3 text-[13px] text-[#9a9ea3] outline-none transition hover:border-[#cfd2cc] focus-visible:border-primary focus-visible:ring-2 focus-visible:ring-primary/20" |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/console/src/app/CommandBar.tsx
Line: 56
Comment:
`w-full` is redundant alongside `flex-1` in a flex context. `flex-1 min-w-0` is sufficient — the initial `flex-basis: 0%` from `flex-1` already drives the growth, and `w-full` can cause the element to briefly claim 100% width before flex distribution kicks in. Removing `w-full` is cleaner.
```suggestion
className="flex h-[34px] flex-1 min-w-0 items-center gap-2 whitespace-nowrap rounded-[9px] border border-border bg-bg px-3 text-[13px] text-[#9a9ea3] outline-none transition hover:border-[#cfd2cc] focus-visible:border-primary focus-visible:ring-2 focus-visible:ring-primary/20"
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Three small top-of-console fixes:
NETWORKdefaults tobenzonet.Gates: build ✓ · typecheck ✓ · lint ✓ · 68 tests.
Summary by CodeRabbit
New Features
UI Improvements
Bug Fixes
Greptile Summary
Three focused UI polish changes: the audit log timezone note is removed (eliminating a layout collision with the date-range input), the network switcher is replaced with a read-only BenzoNet indicator (removing misleading selection UI for a single-chain app), and the command bar now fills available top-bar width via
flex-1instead of a hardcoded 300 px.network.ts/NetworkMenu.tsx:NETWORKnow defaults to\"benzonet\"explicitly; all selection state, localStorage persistence, and theNETWORKSarray are removed — the dropdown becomes a read-only details panel showing chain ID, RPC, and explorer for the active build-time network.CommandBar.tsx/Shell.tsx: the trigger button gainsflex-1 min-w-0and the adjacentflex-1spacer div is dropped, achieving the same right-aligned layout with the search bar filling the gap.AuditLog.tsx: removes the timezone helper span and switches the footer fromjustify-betweentojustify-end, keeping Export CSV right-aligned without the colliding label.Confidence Score: 4/5
Safe to merge — all three changes are self-contained UI adjustments with no data mutations or auth impact.
The network refactor cleanly removes selection logic and localStorage persistence; the NETWORK default change to benzonet is correctly reflected in the updated test. The only item worth a second look is NetworkMenu: the popup panel's role=menu was removed (correct, since it is no longer a selector) but no replacement role or aria-controls linkage was added, leaving the expand/collapse relationship opaque to screen readers.
apps/console/src/app/NetworkMenu.tsx — the popup panel lost its ARIA role without gaining a replacement, worth a small follow-up for accessibility.
Important Files Changed
Comments Outside Diff (1)
apps/console/src/app/NetworkMenu.tsx, line 97-125 (link)The trigger button has
aria-expanded={open}but noaria-controlspointing to the panel'sid, and the panel itself has noidor ARIA role. Screen readers can announce that the button is expanded/collapsed but cannot identify or locate the panel being toggled.Previously the panel carried
role="menu"(which established its own implicit semantics). Now that it's read-only info, something likerole="region"+aria-label="Network details"on the panel, plus a matchingidandaria-controlson the button, would restore a navigable relationship. Without this, keyboard/AT users who rely onaria-expandedto find the disclosed content will get no pointer to where that content lives.Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "polish(console): remove the timezone not..." | Re-trigger Greptile