chore(console): remove em-dashes from copy and comments#71
Merged
Conversation
Sweep every em-dash (357 across the app + shared packages): spaced clause separators become commas, the rest become hyphens. Clears the em-dash tell from all user-facing copy and keeps the codebase consistent.
📝 WalkthroughWalkthroughThis PR normalizes punctuation and wording across console screens, shared packages, comments, accessibility labels, fallback placeholders, test descriptions, and a few error messages. No exported declarations, component behavior, control flow, or test logic were changed. ChangesCopy and documentation normalization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/console/src/screens/Dashboard.tsx`:
- Around line 2-5: Normalize the punctuation and phrasing at all three affected
sites: in apps/console/src/screens/Dashboard.tsx lines 2-5, remove the
duplicated comma in “figure,, when”; in apps/console/src/screens/Contractors.tsx
lines 237-238, rewrite the server-side rate-card tooltip for grammatical
clarity; and in apps/console/src/screens/Contractors.tsx lines 479-487, rewrite
the handle and monthly-rate hints to eliminate comma splices and dangling
phrasing.
In `@apps/console/src/screens/Grants.tsx`:
- Around line 333-335: Replace the comma splice in the paragraph around the
export statement at apps/console/src/screens/Grants.tsx lines 333-335 with a
period or semicolon separating “for a period” from “the total is proven
on-chain.” Apply the same punctuation correction at
apps/console/src/screens/Grants.tsx lines 405-407, separating “you can't undo
it” from “you'd have to grant new access.”
In `@packages/core/src/org.ts`:
- Line 112: Correct the punctuation in the comments at
packages/core/src/org.ts:112-112 by separating the independent clauses with a
period or semicolon; at packages/core/src/reserves.ts:33-33 by replacing the
comma after “Pure” with appropriate sentence punctuation; and at
packages/core/src/zklogin.ts:45-45 by removing the comma between “binding” and
“commits”.
In `@packages/types/src/api.ts`:
- Line 121: Preserve sentence boundaries in the documentation comments by
replacing comma splices: update the `/api/live` description in
packages/types/src/api.ts (line 121), the documentation clauses in
packages/ui/src/index.ts (line 8), and the comma before “it is” plus the comma
at the later site in packages/ui/src/payment-state.ts (lines 4 and 71) with
semicolons, colons, conjunctions, or separate sentences.
In `@packages/ui/src/proving-state.ts`:
- Line 25: Rewrite the comment above the forwarded internal info log as a
complete, clear sentence, avoiding the current fragment and mixed
noun/imperative phrasing while preserving that the state remains “proving” and
the log detail is retained.
In `@packages/ui/src/send-sequence.test.ts`:
- Line 7: Update the describe suite title in the send sequence tests to use
neutral, descriptive wording focused on phase mapping, removing the “slave to
the machine” phrasing while preserving the test behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ac4f7c10-07ab-445d-9f28-d708747673f9
📒 Files selected for processing (91)
apps/console/src/app/NetworkMenu.tsxapps/console/src/app/RootGate.tsxapps/console/src/app/Shell.tsxapps/console/src/app/nav.tsapps/console/src/demo/api.tsapps/console/src/demo/data.tsapps/console/src/lib/copy.tsapps/console/src/lib/format.tsapps/console/src/lib/network.tsapps/console/src/lib/store.test.tsxapps/console/src/lib/store.tsxapps/console/src/screens/Approvals.tsxapps/console/src/screens/AuditLog.tsxapps/console/src/screens/Contractors.tsxapps/console/src/screens/Dashboard.tsxapps/console/src/screens/Grants.tsxapps/console/src/screens/Invoices.tsxapps/console/src/screens/Pay.tsxapps/console/src/screens/Settings.tsxapps/console/src/ui/Logo.tsxapps/console/src/ui/SendCeremony.test.tsxapps/console/src/ui/SendCeremony.tsxapps/console/src/ui/controls.tsxapps/console/src/ui/primitives.tsxpackages/core/src/account-file.tspackages/core/src/account.test.tspackages/core/src/account.tspackages/core/src/client.tspackages/core/src/crypto/bytes.tspackages/core/src/crypto/poseidon2.tspackages/core/src/crypto/random.tspackages/core/src/index.browser.tspackages/core/src/index.tspackages/core/src/kybcredential.tspackages/core/src/merkle.tspackages/core/src/mvk-registry.test.tspackages/core/src/mvk-registry.tspackages/core/src/notes.tspackages/core/src/onboard.tspackages/core/src/org.tspackages/core/src/orgauth.tspackages/core/src/payoutinnocence.tspackages/core/src/payrollcomp.tspackages/core/src/pool.tspackages/core/src/prover.tspackages/core/src/relay.tspackages/core/src/reserves.tspackages/core/src/scanner.tspackages/core/src/scval.tspackages/core/src/spendingcap.tspackages/core/src/stellar-rpc.tspackages/core/src/stellar.tspackages/core/src/store.tspackages/core/src/sum.tspackages/core/src/tx-signer.tspackages/core/src/viewkeys.tspackages/core/src/zklogin.tspackages/core/test/circuits.test.tspackages/core/test/crypto.test.tspackages/core/test/joinsplit-org.test.tspackages/core/test/kyc-issuer-integration.test.tspackages/core/test/mvk-registry.test.tspackages/core/test/notekey.test.tspackages/core/test/org-note-spend.test.tspackages/core/test/org-spend-auth.test.tspackages/core/test/parity.test.tspackages/core/test/reserves.test.tspackages/core/test/scanner.test.tspackages/core/test/selectnotes.test.tspackages/core/test/tx-signer.test.tspackages/core/test/wasm.test.tspackages/links/src/index.tspackages/types/src/accounts.tspackages/types/src/api.tspackages/types/src/approvals.tspackages/types/src/common.tspackages/types/src/compliance.tspackages/types/src/index.tspackages/types/src/invoices.tspackages/types/src/org.tspackages/types/src/payments.tspackages/ui/src/balance.tspackages/ui/src/format.tspackages/ui/src/hooks.tspackages/ui/src/index.tspackages/ui/src/payment-state.tspackages/ui/src/proving-state.tspackages/ui/src/send-sequence.test.tspackages/ui/src/send-sequence.tspackages/ui/src/wallet-state.tspackages/ui/test/format.test.ts
Comment on lines
+2
to
+5
| * Dashboard / Overview, calm, dense enterprise-finance home. A compact setup | ||
| * banner (only when setup is unfinished), the private treasury balance, the one | ||
| * approval awaiting the current member, and a real recent-activity table. Amounts | ||
| * follow one rule: •••••• only when the viewer can't see the figure, — when there | ||
| * follow one rule: •••••• only when the viewer can't see the figure,, when there |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct punctuation-normalization copy regressions.
The sweep left several strings with duplicated punctuation or comma-splice phrasing:
apps/console/src/screens/Dashboard.tsx#L2-L5: remove the duplicated comma infigure,, when.apps/console/src/screens/Contractors.tsx#L237-L238: rewrite the server-side rate-card tooltip for grammatical clarity.apps/console/src/screens/Contractors.tsx#L479-L487: rewrite the handle and monthly-rate hints to avoid comma splices and dangling phrasing.
📍 Affects 2 files
apps/console/src/screens/Dashboard.tsx#L2-L5(this comment)apps/console/src/screens/Contractors.tsx#L237-L238apps/console/src/screens/Contractors.tsx#L479-L487
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/console/src/screens/Dashboard.tsx` around lines 2 - 5, Normalize the
punctuation and phrasing at all three affected sites: in
apps/console/src/screens/Dashboard.tsx lines 2-5, remove the duplicated comma in
“figure,, when”; in apps/console/src/screens/Contractors.tsx lines 237-238,
rewrite the server-side rate-card tooltip for grammatical clarity; and in
apps/console/src/screens/Contractors.tsx lines 479-487, rewrite the handle and
monthly-rate hints to eliminate comma splices and dangling phrasing.
Comment on lines
+333
to
335
| Export a network-verified statement of what you paid out for a period, the total is proven on-chain; the individual | ||
| salaries stay hidden. The file embeds the proof so your auditor can re-verify it independently. | ||
| </p> |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Avoid comma splices introduced by the punctuation sweep.
Replacing the em-dash with a comma makes both sentences grammatically incorrect. Use a period or semicolon at each site.
apps/console/src/screens/Grants.tsx#L333-L335: Separate “for a period” from “the total is proven on-chain.”apps/console/src/screens/Grants.tsx#L405-L407: Separate “you can't undo it” from “you'd have to grant new access.”
📍 Affects 1 file
apps/console/src/screens/Grants.tsx#L333-L335(this comment)apps/console/src/screens/Grants.tsx#L405-L407
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/console/src/screens/Grants.tsx` around lines 333 - 335, Replace the
comma splice in the paragraph around the export statement at
apps/console/src/screens/Grants.tsx lines 333-335 with a period or semicolon
separating “for a period” from “the total is proven on-chain.” Apply the same
punctuation correction at apps/console/src/screens/Grants.tsx lines 405-407,
separating “you can't undo it” from “you'd have to grant new access.”
| * spendMessage = Poseidon(nullifier0, nullifier1, outCommitment0, outCommitment1). | ||
| * Derived from the (public) nullifiers + output commitments, so any change to | ||
| * the spend invalidates the signatures — they must be collected LAST. | ||
| * the spend invalidates the signatures, they must be collected LAST. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the punctuation introduced by the normalization sweep.
These comments remain behaviorally harmless but are grammatically incorrect or ambiguous:
packages/core/src/org.ts#L112-L112: separate the two independent clauses with a period or semicolon.packages/core/src/reserves.ts#L33-L33: replace the comma after “Pure” with appropriate sentence punctuation.packages/core/src/zklogin.ts#L45-L45: remove the comma between “binding” and “commits”.
📍 Affects 3 files
packages/core/src/org.ts#L112-L112(this comment)packages/core/src/reserves.ts#L33-L33packages/core/src/zklogin.ts#L45-L45
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/core/src/org.ts` at line 112, Correct the punctuation in the
comments at packages/core/src/org.ts:112-112 by separating the independent
clauses with a period or semicolon; at packages/core/src/reserves.ts:33-33 by
replacing the comma after “Pure” with appropriate sentence punctuation; and at
packages/core/src/zklogin.ts:45-45 by removing the comma between “binding” and
“commits”.
| } | ||
|
|
||
| /** GET /api/live — is the BFF wired to live testnet, and if not, why. */ | ||
| /** GET /api/live, is the BFF wired to live testnet, and if not, why. */ |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Preserve sentence boundaries during punctuation normalization.
Several replacements introduce comma splices. Use semicolons, colons, conjunctions, or separate sentences at each site.
packages/types/src/api.ts#L121-L121: rephrase the/api/livedescription or replace the comma after the endpoint.packages/ui/src/index.ts#L8-L8: replace the comma between the documentation clauses with a semicolon or conjunction.packages/ui/src/payment-state.ts#L4-L4: replace the comma before “it is” with a semicolon.packages/ui/src/payment-state.ts#L71-L71: replace the comma with a semicolon.
📍 Affects 3 files
packages/types/src/api.ts#L121-L121(this comment)packages/ui/src/index.ts#L8-L8packages/ui/src/payment-state.ts#L4-L4packages/ui/src/payment-state.ts#L71-L71
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/types/src/api.ts` at line 121, Preserve sentence boundaries in the
documentation comments by replacing comma splices: update the `/api/live`
description in packages/types/src/api.ts (line 121), the documentation clauses
in packages/ui/src/index.ts (line 8), and the comma before “it is” plus the
comma at the later site in packages/ui/src/payment-state.ts (lines 4 and 71)
with semicolons, colons, conjunctions, or separate sentences.
| if (stage === "done") return { phase: "done", label: "Proof ready", raw: stage }; | ||
| if (stage === "proving") return { phase: "proving", label: "Generating proof on your device…", raw: stage }; | ||
| // A forwarded internal info log — stay in "proving" but keep the detail. | ||
| // A forwarded internal info log, stay in "proving" but keep the detail. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Clarify the forwarded-log comment.
The current wording is a fragment and awkwardly mixes a noun with an imperative.
Suggested wording
- // A forwarded internal info log, stay in "proving" but keep the detail.
+ // Forwarded internal info logs keep the phase in "proving" while preserving detail.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // A forwarded internal info log, stay in "proving" but keep the detail. | |
| // Forwarded internal info logs keep the phase in "proving" while preserving detail. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ui/src/proving-state.ts` at line 25, Rewrite the comment above the
forwarded internal info log as a complete, clear sentence, avoiding the current
fragment and mixed noun/imperative phrasing while preserving that the state
remains “proving” and the log detail is retained.
| const at = (phase: PaymentState["phase"], extra: Partial<PaymentState> = {}): PaymentState => ({ phase, ...extra }); | ||
|
|
||
| describe("send ceremony — phase mapping (slave to the machine)", () => { | ||
| describe("send ceremony, phase mapping (slave to the machine)", () => { |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use neutral, descriptive test-suite wording.
"slave to the machine" is ambiguous and distracts from the phase-mapping behavior. Prefer a direct title such as "send ceremony, phase mapping".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ui/src/send-sequence.test.ts` at line 7, Update the describe suite
title in the send sequence tests to use neutral, descriptive wording focused on
phase mapping, removing the “slave to the machine” phrasing while preserving the
test behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes every em-dash (—) from the console app + shared packages (357 occurrences across 91 files). Mechanical + safe (
—never appears in code logic): spaced clause-separator—becomes,; any remaining—becomes-.Covers all screen/UI copy and comments so none linger.
Build ✓ · lint ✓ · 78/78 tests · 0 em-dashes remaining.
Greptile Summary
This PR removes em-dashes from console and shared package text.
Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "chore(console): remove em-dashes from co..." | Re-trigger Greptile