[pull] master from Homebrew:master #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
Bumps the sorbet group in /Library/Homebrew with 4 updates: [sorbet-static-and-runtime](https://github.com/sorbet/sorbet), [sorbet-runtime](https://github.com/sorbet/sorbet), [sorbet](https://github.com/sorbet/sorbet) and [sorbet-static](https://github.com/sorbet/sorbet). Updates `sorbet-static-and-runtime` from 0.5.11805 to 0.5.11810 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `sorbet-runtime` from 0.5.11805 to 0.5.11810 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `sorbet` from 0.5.11805 to 0.5.11810 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `sorbet-static` from 0.5.11805 to 0.5.11810 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet-static-and-runtime dependency-type: direct:development update-type: version-update:semver-patch dependency-group: sorbet - dependency-name: sorbet-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: sorbet - dependency-name: sorbet dependency-type: indirect update-type: version-update:semver-patch dependency-group: sorbet - dependency-name: sorbet-static dependency-type: indirect update-type: version-update:semver-patch dependency-group: sorbet ... Signed-off-by: dependabot[bot] <[email protected]>
Import these from the homebrew/formula-analytics tap and deprecate that tap. This required a little messing around with filenames and paths to get it finding Python and writing to the user's home directory.
…letions Update manpage and completions.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
…mebrew/sorbet-f0dcbe9041 build(deps): bump the sorbet group in /Library/Homebrew with 4 updates
- So we don't forget to add it to new docs we write.
Enforce that all docs have `last_review_date` frontmatter
- Most of these were fine still, apart from: - FAQ: `hub` is less maintained than `gh`. - Brew-Maintainer-Guide: link to GitHub docs on commit signing via GPG or SSH. - Interesting-Taps-and-Forks: remove outdated information about `homebrew/core` being in `Library/Taps`. - New-Maintainer-Checklist: remove outdated information about the `@members` team.
Review some docs
utils/pypi: remove extra newline when updating resources
- Some of these I bumped to `typed: strict`, some of them I added intermediary type signatures to some of the methods to make my life easier in the (near, hopefully) future. - Turns out that RuboCop node matchers that end in `?` can return `nil` if they don't match anything, not `false`.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
Import `brew formula-analytics` and `generate-analytics-api` commands
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
Bumps [codecov/test-results-action](https://github.com/codecov/test-results-action) from 1.0.2 to 1.0.3. - [Release notes](https://github.com/codecov/test-results-action/releases) - [Commits](codecov/test-results-action@4e79e65...44ecb3a) --- updated-dependencies: - dependency-name: codecov/test-results-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/create-github-app-token](https://github.com/actions/create-github-app-token) from 1.11.2 to 1.11.3. - [Release notes](https://github.com/actions/create-github-app-token/releases) - [Commits](actions/create-github-app-token@136412a...67e27a7) --- updated-dependencies: - dependency-name: actions/create-github-app-token dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.8.0 to 3.9.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@6524bf6...f7ce87c) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.215.0 to 1.218.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@2654679...d781c1b) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the sorbet group in /Library/Homebrew with 4 updates: [sorbet-static-and-runtime](https://github.com/sorbet/sorbet), [sorbet-runtime](https://github.com/sorbet/sorbet), [sorbet](https://github.com/sorbet/sorbet) and [sorbet-static](https://github.com/sorbet/sorbet). Updates `sorbet-static-and-runtime` from 0.5.11810 to 0.5.11812 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `sorbet-runtime` from 0.5.11810 to 0.5.11812 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `sorbet` from 0.5.11810 to 0.5.11812 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `sorbet-static` from 0.5.11810 to 0.5.11812 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet-static-and-runtime dependency-type: direct:development update-type: version-update:semver-patch dependency-group: sorbet - dependency-name: sorbet-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: sorbet - dependency-name: sorbet dependency-type: indirect update-type: version-update:semver-patch dependency-group: sorbet - dependency-name: sorbet-static dependency-type: indirect update-type: version-update:semver-patch dependency-group: sorbet ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.8 to 3.28.9. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@dd74661...9e8d078) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…letions Update manpage and completions.
…y/setup-ruby-1.218.0 build(deps): bump ruby/setup-ruby from 1.215.0 to 1.218.0
…ions/create-github-app-token-1.11.3 build(deps): bump actions/create-github-app-token from 1.11.2 to 1.11.3
…hub/codeql-action-3.28.9 build(deps): bump github/codeql-action from 3.28.8 to 3.28.9
…ker/setup-buildx-action-3.9.0 build(deps): bump docker/setup-buildx-action from 3.8.0 to 3.9.0
Enable strict typing in Formula
Followup to #19323.
diagnostic: fix call to missing_dependencies
These are new and shiny so let's use them.
.github/ISSUE_TEMPLATE/*: use issue types.
A space-separated list of casks. Homebrew will act as if `--greedy` was passed when upgrading any cask on this list.
Add `HOMEBREW_UPGRADE_GREEDY_CASKS`
This adds a `Livecheck::Options` class, which is intended to house various configuration options that are set in `livecheck` blocks, conditionally set by livecheck at runtime, etc. The general idea is that when we add features involving configurations options (e.g., for livecheck, strategies, curl, etc.), we can make changes to `Options` without needing to modify parameters for strategy `find_versions` methods, `Strategy` methods like `page_headers` and `page_content`, etc. This is something that I've been trying to improve over the years and `Options` should help to reduce maintenance overhead in this area while also strengthening type signatures. `Options` replaces the existing `homebrew_curl` option (which related strategies pass to `Strategy` methods and on to `curl_args`) and the new `url_options` (which contains `post_form` or `post_json` values that are used to make `POST` requests). I recently added `url_options` as a temporary way of enabling `POST` support without `Options` but this restores the original `Options`-based implementation. Along the way, I added a `homebrew_curl` parameter to the `url` DSL method, allowing us to set an explicit value in `livecheck` blocks. This is something that we've needed in some cases but I also intend to replace implicit/inferred `homebrew_curl` usage with explicit values in `livecheck` blocks once this is available for use. My intention is to eventually remove the implicit behavior and only rely on explicit values. That will align with how `homebrew_curl` options work for other URLs and makes the behavior clear just from looking at the `livecheck` block. Lastly, this removes the `unused` rest parameter from `find_versions` methods. I originally added `unused` as a way of handling parameters that some `find_versions` methods have but others don't (e.g., `cask` in `ExtractPlist`), as this allowed us to pass various arguments to `find_versions` methods without worrying about whether a particular parameter is available. This isn't an ideal solution and I originally wanted to handle this situation by only passing expected arguments to `find_versions` methods but there was a technical issue standing in the way. I recently found an answer to the issue, so this also replaces the existing `ExtractPlist` special case with generic logic that checks the parameters for a strategy's `find_versions` method and only passes expected arguments. Replacing the aforementioned `find_versions` parameters with `Options` ensures that the remaining parameters are fairly consistent across strategies and any differences are handled by the aforementioned logic. Outside of `ExtractPlist`, the only other difference is that some `find_versions` methods have a `provided_content` parameter but that's currently only used by tests (though it's intended for caching support in the future). I will be renaming that parameter to `content` in an upcoming PR and expanding it to the other strategies, which should make them all consistent outside of `ExtractPlist`.
As suggested, this reworks `Options` to subclass `T::Struct`, which simplifies the implementation and makes it easier to maintain. One noteworthy difference in switching to `T::Struct` is that `#serialize` omits `nil` values but I don't _think_ this should be a problem for us. In terms of changes, I modified `#merge` to remove a now-unnecessary `compact` call and updated related tests. Co-authored-by: Douglas Eichelberger <[email protected]>
This enables `typed: strong` in `Options` and resolves the related errors. I annotated the return value of `serialize` in `#to_hash` to resolve a type error and then updated other methods to use `to_hash` instead. This approach resolves similar type errors without duplicating the same `serialize` annotation. For `#==`, I switched `instance_of?(other.class)` to `other.is_a?(Options)`, as Sorbet understands that `is_a?` ensures `other` is an `Options` object but doesn't seem to understand that `instance_of?` was doing the same thing. The tests continue to pass with these changes, so hopefully this is fine.
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
livecheck: add Options class
…letions Update manpage and completions.
Fix return type of Formula.build
Bumps [setuptools](https://github.com/pypa/setuptools) from 75.8.0 to 75.8.1. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v75.8.0...v75.8.1) --- updated-dependencies: - dependency-name: setuptools dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the sorbet group in /Library/Homebrew with 4 updates: [sorbet-static-and-runtime](https://github.com/sorbet/sorbet), [sorbet-runtime](https://github.com/sorbet/sorbet), [sorbet](https://github.com/sorbet/sorbet) and [sorbet-static](https://github.com/sorbet/sorbet). Updates `sorbet-static-and-runtime` from 0.5.11851 to 0.5.11856 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `sorbet-runtime` from 0.5.11851 to 0.5.11856 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `sorbet` from 0.5.11851 to 0.5.11856 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) Updates `sorbet-static` from 0.5.11851 to 0.5.11856 - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet-static-and-runtime dependency-type: direct:development update-type: version-update:semver-patch dependency-group: sorbet - dependency-name: sorbet-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: sorbet - dependency-name: sorbet dependency-type: indirect update-type: version-update:semver-patch dependency-group: sorbet - dependency-name: sorbet-static dependency-type: indirect update-type: version-update:semver-patch dependency-group: sorbet ... Signed-off-by: dependabot[bot] <[email protected]>
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
…mebrew/sorbet-2d80ecae37 build(deps): bump the sorbet group in /Library/Homebrew with 4 updates
…ew/formula-analytics/setuptools-75.8.1 build(deps): bump setuptools from 75.8.0 to 75.8.1 in /Library/Homebrew/formula-analytics
fix: Revert breaking type change in Formula#std_npm_args
docs: Remove misused YARD directives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )