Data type reading in .npy files#14
Merged
Algiane merged 3 commits intoMmgTools:developfrom Feb 29, 2024
Merged
Conversation
Algiane
reviewed
Feb 26, 2024
Member
There was a problem hiding this comment.
Thanks for this fix.
-
I think that we need to improve the readibility before merging this : I propose to define macros at file begining to allow the user to easily understand the meaning of the hex code and to add at least comments on what is readed in the header.
-
Is it possible to add 2 minimal .npy files with different data sizes to illustrate this PR (so we can easily see that the develop branch fails to read a file with a wrong data size).
…odified reading method for data type in header
Author
|
Member
|
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update allows hex2tet to read the data size contained in the file, in order to read data properly.