Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,15 @@
"prepare": "husky"
},
"lint-staged": {
"*.{js,jsx,ts,tsx}": ["biome check"]
"*.{js,jsx,ts,tsx}": [
"biome check"
]
},
"dependencies": {
"@emotion/react": "^11.14.0",
"@emotion/styled": "^11.13.5",
"@radix-ui/colors": "^3.0.0",
"@radix-ui/react-icons": "^1.3.2",
"@radix-ui/themes": "^3.1.6",
"@tanstack/react-query": "^5.62.10",
"@tanstack/react-query-devtools": "^5.62.11",
Expand Down
12 changes: 12 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/Menu/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { Link } from "react-router";
export default function MenuPage() {
return (
<>
<Header left={"왼쪽"} center={"중앙"} right={"오른쪽"} />
<Header title={"중앙"} />
{version}
<Card variant="surface">menu</Card>

Expand Down
82 changes: 75 additions & 7 deletions src/common/components/Header.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,86 @@
import styled from "@emotion/styled";
import { ChevronLeftIcon } from "@radix-ui/react-icons";
import type { ReactElement } from "react";
import { useNavigate } from "react-router";
import { Z_INDEX } from "../constants/zIndex";
import { rem } from "../utils/rem";

/**
* Header 컴포넌트 Props
*
* 우선순위: render* > backButton, title > 기본 뒤로가기 버튼
*/
interface HeaderProps {
left?: ReactElement | string;
center: ReactElement | string;
right?: ReactElement | string;
/** 백 버튼 커스터마이징 */
backButton?: {
renderIcon?: () => ReactElement;
onClick?: () => void;
};
/** 헤더 제목 */
title?: string;
/** 왼쪽 섹션 커스터마이징 */
renderLeft?: () => ReactElement;
/** 중앙 섹션 커스터마이징 */
renderCenter?: () => ReactElement;
/** 오른쪽 섹션 커스터마이징 */
renderRight?: () => ReactElement;
}

function Header({ left, center, right }: HeaderProps) {
/**
* 페이지 헤더 컴포넌트
*
* @example
* ```tsx
* // default (backButton, title)
* <Header title="홈" />
*
* // backButton ui, 이벤트 커스터마이징
* <Header title="설정" backButton={{ onClick: () => navigate('/') }} />
*
* // 섹션별 커스터마이징 (renderLeft, renderCenter, renderRight)
* <Header renderCenter={() => <SearchBar />} />
* ```
*/
function Header({ backButton, title, renderLeft, renderCenter, renderRight }: HeaderProps) {
const navigate = useNavigate();

const renderBackButton = () => {
const onClickBackButton = () => {
if (backButton && "onClick" in backButton && backButton.onClick) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"onClick" in backButton // backButton에 onClick prop이 있는지 확인
backButton.onClick // onClick에 nullish한 값이 들어오지는 않았는지 검증 용도

연서한테 구두로 설명받았습니다~!

backButton.onClick();
return;
}
// default behavior
navigate(-1);
};

return (
<button type="button" onClick={onClickBackButton}>

Copilot AI Jul 6, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an accessible name (e.g., aria-label="뒤로가기") to the back button so screen readers can identify its purpose.

Suggested change
<button type="button" onClick={onClickBackButton}>
<button
type="button"
onClick={onClickBackButton}
aria-label={backButton?.ariaLabel || "뒤로가기"} // Default accessible name
>

Copilot uses AI. Check for mistakes.
{(() => {
if (backButton && "renderIcon" in backButton && backButton.renderIcon) {
return backButton.renderIcon();
}
// default back button icon
return <ChevronLeftIcon width={28} height={28} />;
})()}
</button>
);
};

const renderCenterElement = () => renderCenter && <CenterElement as="div">{renderCenter()}</CenterElement>;

const renderTitleElement = () =>
title && (
<CenterElement as="h1" css={{ fontSize: rem(1.8), fontWeight: "700" }}>
{title}
</CenterElement>
);

return (
<HeaderWrapper aria-label="페이지 헤더">
<LeftElement>{left}</LeftElement>
<CenterElement as={typeof center === "string" ? "h1" : "div"}>{center}</CenterElement>
<RightElement>{right}</RightElement>
<LeftElement>{renderLeft?.() ?? renderBackButton()}</LeftElement>
{renderCenterElement() ?? renderTitleElement()}
<RightElement>{renderRight?.()}</RightElement>
</HeaderWrapper>
);
}
Expand All @@ -31,6 +98,7 @@ const HeaderWrapper = styled.header({
height: "4.8rem",

backgroundColor: "white",
boxShadow: "0 2px 4px 0 rgba(0, 0, 0, 0.1)",
});

const LeftElement = styled.div({
Expand Down