fix(github): correctly convert file:
URL to path
#131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for nodejs/node#48409
When the path contains URL-significant chars (e.g.
%
,?
,#
), it breaks the reporter. Also, usingrequire.resolve
to resolve relative paths will be problematic as it would resolve it relatively from the current reporter module instead of the CWD. Usingpath.resolve
should be a better fit.