Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): correctly convert file: URL to path #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aduh95
Copy link

@aduh95 aduh95 commented Oct 22, 2024

Needed for nodejs/node#48409

When the path contains URL-significant chars (e.g. %, ?, #), it breaks the reporter. Also, using require.resolve to resolve relative paths will be problematic as it would resolve it relatively from the current reporter module instead of the CWD. Using path.resolve should be a better fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant