Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include <functional> in Demangle.h #59

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Include <functional> in Demangle.h #59

merged 1 commit into from
Mar 28, 2024

Conversation

etbrady
Copy link
Contributor

@etbrady etbrady commented Mar 28, 2024

This resolves a build error when using Bazel to build on Xcode 15.3

In file included from external/swift-index-store~/Sources/CSwiftDemangle/CSwiftDemangle.cpp:1:
external/swift-index-store~/Sources/CSwiftDemangle/PrivateHeaders/include/swift/Demangling/Demangle.h:61:8: error: no template named 'function' in namespace 'std'
  std::function<std::string(uint64_t, uint64_t)> GenericParameterName =
  ~~~~~^
1 error generated.
Error in child process '/usr/bin/xcrun'. 1

@etbrady etbrady requested a review from keith as a code owner March 28, 2024 17:14
@etbrady
Include <functional> in Demangle.h
a8b7250 
This resolves a build error when using Bazel to build on Xcode 15.3

Signed-off-by: Ethan Brady <[email protected]>
@keith keith enabled auto-merge (squash) March 28, 2024 17:33
keith
keith approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks, we should probably re-sync these headers since they're copied from upstream, but doesn't hurt to patch in the meantime to unblock!

@keith keith merged commit 7a07270 into MobileNativeFoundation:main Mar 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etbrady @keith