Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-17418] fix postgres version #66

Closed
wants to merge 2 commits into from
Closed

Conversation

dmitry-pedchenko
Copy link
Contributor

@dmitry-pedchenko dmitry-pedchenko commented Jun 24, 2024

Change Summary

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus
Copy link
Member

Но зачем?

@dmitry-pedchenko
Copy link
Contributor Author

Но зачем?

если не указывать ставится 16я версия и она ругается что там какие-то файлы для 15й версии а стоит 16я

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (04e569e) to head (50185e4).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #66   +/-   ##
========================================
  Coverage    92.86%   92.86%           
========================================
  Files           84       84           
  Lines         2452     2452           
  Branches       309      309           
========================================
  Hits          2277     2277           
  Misses         122      122           
  Partials        53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus
Copy link
Member

Ну у тебя просто volume для postgres создан 15 версией, его нужно пересоздать

@dmitry-pedchenko
Copy link
Contributor Author

Ну у тебя просто volume для postgres создан 15 версией, его нужно пересоздать

вот да тоже подумал только что видимо там в вольюме файлики эти для старой версии, а для работы с бэком не нужно фиксировать версию?

@dolfinus
Copy link
Member

Зачем ее фиксировать? У нас ничего не версию Postgres не завязано

@dmitry-pedchenko
Copy link
Contributor Author

Зачем ее фиксировать? У нас ничего не версию Postgres не завязано

ок, тогда дропну это изменение

@dolfinus dolfinus closed this Jun 24, 2024
@dolfinus dolfinus deleted the bugfix/DOP-17418 branch June 24, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants