Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval modalities #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Eval modalities #1

wants to merge 10 commits into from

Conversation

rrutmann
Copy link
Collaborator

@rrutmann rrutmann commented Feb 5, 2024

We add support for models trained with https://github.com/Modalities/modalities

@rrutmann rrutmann self-assigned this Feb 5, 2024
@mrudat-iais
Copy link

Since I didn't create the PR, I cannot add reviewers. @fromm-m could you please have a look? It is only minor changes to adapt the eval-harness to our modalities repo. I suggest look at the tests first.

def _model_call(
self, inputs: TokenSequence, labels: Optional[TokenSequence] = None
) -> TokenSequence:
return self.model(inputs)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is labels never needed?

tests/test_models.py Outdated Show resolved Hide resolved
tests/test_models.py Outdated Show resolved Hide resolved
tests/test_models.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
5 participants