Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Contrastive Captioner (CoCa) #16

Merged
merged 80 commits into from
Mar 27, 2024
Merged

Add Contrastive Captioner (CoCa) #16

merged 80 commits into from
Mar 27, 2024

Conversation

spravil
Copy link
Member

@spravil spravil commented Jan 22, 2024 •
edited
Loading

This PR has the following updates:

  • Adds einops as dependency
  • Creates the nn subpackage for reuseable modules
  • Adds attention with cross-attention and non-causal sequence modeling
  • Adds the vision transformer (https://arxiv.org/abs/2010.11929)
  • Adds coca (https://arxiv.org/abs/2205.01917)
  • Adds attention pooling
  • Add test for coca forward function
  • Add full integration test (with dataloading mock)

@spravil spravil added the enhancement New feature or request label Jan 22, 2024
@spravil spravil self-assigned this Jan 22, 2024
@spravil spravil marked this pull request as ready for review January 26, 2024 11:55
@lllAlexanderlll lllAlexanderlll requested review from BlueCrescent and removed request for le1nux and mali-git February 19, 2024 08:27
spravil and others added 19 commits February 19, 2024 10:38
@spravil
feat: add non-causal attention and cross-attention
3a47e2e
@spravil
feat: add mlp
c50dbb8
@spravil
chore: add einops
aae4e58
@spravil
feat: add vision transformer
c8d5bf1
@spravil
feat: add coca
55efc2c
@spravil
fix: init of vit transformer block
503b30f
@spravil
fix: use correct gpt2 config
d985f47
@spravil
fix: use correct cls token position
8981cbc
@spravil
test: add test for coca
9738078
@spravil
refactor: use einops rearrange layer instead of function
d12e547
@SogolHaghighat @spravil
feat: add attentional pooling layer
384d902
@SogolHaghighat @spravil
test: update coca test config to run with attentional pooling
31c09ec
@SogolHaghighat @spravil
refactor: use LayerNorm with no bias for attentional pooling
a7cee54
@SogolHaghighat @spravil
refactor: add LayerNorm variables to coca test config
3575945
@SogolHaghighat @spravil
test: add test for attentional pooling layer
f19a728
@spravil
feat: add dummy dataset
4355065
@spravil
fix: add missing bias buffer to attention
b868944
@spravil
fix: fix attention in coca multimodal decoder
dd38b88
@spravil
fix: update init function of coca
676bb66
@spravil spravil requested review from flxst and le1nux March 8, 2024 17:50
@le1nux le1nux force-pushed the main branch 3 times, most recently from cb6e816 to 179052b Compare March 13, 2024 22:14
@flxst flxst mentioned this pull request Mar 15, 2024
Open
1 task
flxst
flxst reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@flxst flxst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments and suggestions which are mostly about code quality / readability.

src/modalities/models/coca/coca_model.py Show resolved Hide resolved
src/modalities/models/coca/coca_model.py Show resolved Hide resolved
src/modalities/models/coca/coca_model.py Outdated Show resolved Hide resolved
src/modalities/models/coca/coca_model.py Outdated Show resolved Hide resolved
src/modalities/models/coca/multi_modal_decoder.py Outdated Show resolved Hide resolved
src/modalities/models/coca/multi_modal_decoder.py Outdated Show resolved Hide resolved
src/modalities/models/vision_transformer/vision_transformer_model.py Outdated Show resolved Hide resolved
src/modalities/nn/attention.py Outdated Show resolved Hide resolved
@flxst flxst self-requested a review March 22, 2024 11:23
flxst
flxst reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@flxst flxst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 1-2 suggestions for improvement related to commit f415271

src/modalities/models/coca/multi_modal_decoder.py Outdated Show resolved Hide resolved
src/modalities/models/coca/multi_modal_decoder.py Show resolved Hide resolved
le1nux
le1nux approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@le1nux le1nux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Good work!

config_files/config.yaml Show resolved Hide resolved
config_files/config_example_openGPTx_dataset.yaml Outdated Show resolved Hide resolved
examples/getting_started/README.md Show resolved Hide resolved
@le1nux le1nux merged commit 60feafe into main Mar 27, 2024
@le1nux le1nux deleted the feat/coca branch March 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaschhh thomaschhh thomaschhh left review comments

@le1nux le1nux le1nux approved these changes

@BlueCrescent BlueCrescent BlueCrescent approved these changes

@flxst flxst flxst approved these changes

Assignees

@spravil spravil

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spravil @le1nux @BlueCrescent @flxst @thomaschhh @SogolHaghighat