Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contrastive Captioner (CoCa) #16

Merged
merged 80 commits into from
Mar 27, 2024
Merged

Add Contrastive Captioner (CoCa) #16

merged 80 commits into from
Mar 27, 2024

Conversation

spravil
Copy link
Member

@spravil spravil commented Jan 22, 2024

This PR has the following updates:

  • Adds einops as dependency
  • Creates the nn subpackage for reuseable modules
  • Adds attention with cross-attention and non-causal sequence modeling
  • Adds the vision transformer (https://arxiv.org/abs/2010.11929)
  • Adds coca (https://arxiv.org/abs/2205.01917)
  • Adds attention pooling
  • Add test for coca forward function
  • Add full integration test (with dataloading mock)

@spravil spravil added the enhancement New feature or request label Jan 22, 2024
@spravil spravil self-assigned this Jan 22, 2024
@spravil spravil marked this pull request as ready for review January 26, 2024 11:55
@lllAlexanderlll lllAlexanderlll requested review from BlueCrescent and removed request for le1nux and mali-git February 19, 2024 08:27
Copy link
Member

@flxst flxst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments and suggestions which are mostly about code quality / readability.

src/modalities/models/coca/coca_model.py Show resolved Hide resolved
src/modalities/models/coca/coca_model.py Show resolved Hide resolved
src/modalities/models/coca/coca_model.py Outdated Show resolved Hide resolved
src/modalities/models/coca/coca_model.py Outdated Show resolved Hide resolved
src/modalities/models/coca/multi_modal_decoder.py Outdated Show resolved Hide resolved
src/modalities/models/coca/multi_modal_decoder.py Outdated Show resolved Hide resolved
src/modalities/nn/attention.py Outdated Show resolved Hide resolved
@flxst flxst self-requested a review March 22, 2024 11:23
Copy link
Member

@flxst flxst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 1-2 suggestions for improvement related to commit f415271

src/modalities/models/coca/multi_modal_decoder.py Outdated Show resolved Hide resolved
Copy link
Member

@le1nux le1nux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Good work!

config_files/config.yaml Show resolved Hide resolved
config_files/config_example_openGPTx_dataset.yaml Outdated Show resolved Hide resolved
examples/getting_started/README.md Show resolved Hide resolved
@le1nux le1nux merged commit 60feafe into main Mar 27, 2024
@le1nux le1nux deleted the feat/coca branch March 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants